Opened 8 years ago

Closed 7 years ago

Last modified 7 years ago

#26682 closed New feature (fixed)

Support Oracle 12c identity columns

Reported by: Emma Arandjelovic Owned by: Mariusz Felisiak
Component: Database layer (models, ORM) Version: dev
Severity: Normal Keywords: Oracle
Cc: Triage Stage: Ready for checkin
Has patch: yes Needs documentation: no
Needs tests: no Patch needs improvement: no
Easy pickings: no UI/UX: no

Description

Oracle 12c introduced the ability to create an identity column which avoids the need for triggers:

https://oracle-base.com/articles/12c/identity-columns-in-oracle-12cr1

This mechanism performs better than the trigger based approach and is now the recommended best practice. Would it be possible for the migrations framework to support the generation of tables using this new syntax?

Change History (8)

comment:1 by Simon Charette, 8 years ago

Triage Stage: UnreviewedAccepted
Version: 1.9master

I suppose yes. We'd still have to figure out what to do with the existing tables using triggers.

comment:2 by Emma Arandjelovic, 8 years ago

Great, thanks for the quick response!

comment:3 by Jani Tiainen, 8 years ago

One option could be adding this as a flag to database settings stating that this uses 12c identity columns.

To handle old triggers I think it would be enough to document upgrade path if someone wants to turn this feature on after some of the models are generated.

comment:4 by Mariusz Felisiak, 7 years ago

Owner: changed from nobody to Mariusz Felisiak
Status: newassigned

comment:5 by Mariusz Felisiak, 7 years ago

Component: MigrationsDatabase layer (models, ORM)
Has patch: set

comment:6 by Tim Graham, 7 years ago

Triage Stage: AcceptedReady for checkin

comment:7 by Mariusz Felisiak <felisiak.mariusz@…>, 7 years ago

Resolution: fixed
Status: assignedclosed

In 924a89e1:

Fixed #26682 -- Added support for Oracle identity columns.

Thanks Shai Berger and Tim Graham for reviews.

comment:8 by Mariusz Felisiak <felisiak.mariusz@…>, 7 years ago

In 9af6c975:

Refs #26682 -- Added AutoField introspection on Oracle.

Note: See TracTickets for help on using tickets.
Back to Top