Opened 8 years ago

Closed 8 years ago

Last modified 8 years ago

#26674 closed Bug (fixed)

i18n makemessages test failure on Python 3.5 + Windows

Reported by: Ramiro Morales Owned by: Ramiro Morales
Component: Internationalization Version: 1.10
Severity: Normal Keywords: windows unicode
Cc: Triage Stage: Ready for checkin
Has patch: yes Needs documentation: no
Needs tests: no Patch needs improvement: no
Easy pickings: no UI/UX: no

Description

This is the failure:

======================================================================
FAIL: test_special_char_extracted (i18n.test_extraction.BasicExtractorTests)
----------------------------------------------------------------------
Traceback (most recent call last):
  File "C:\django\tests\i18n\test_extraction.py", line 219, in test_special_char_extracted
  File "C:\django\tests\i18n\test_extraction.py", line 87, in assertMsgId
  File "C:\django\tests\i18n\test_extraction.py", line 84, in _assertPoKeyword
AssertionError: None is not true : Could not find 'msgid "Non-breaking space▒:"' in generated PO file

Change History (5)

comment:1 by Ramiro Morales, 8 years ago

Owner: changed from nobody to Ramiro Morales
Status: new → assigned

comment:2 by Ramiro Morales, 8 years ago

Summary: i18n makemessages test failure on Python 3.x + Windows → i18n makemessages test failure on Python 3.5 + Windows

comment:3 by Tim Graham, 8 years ago

Has patch: set
Triage Stage: Accepted → Ready for checkin
Version: master → 1.10

​PR

comment:4 by Ramiro Morales <cramm0@…>, 8 years ago

Resolution: → fixed
Status: assigned → closed

In 1b00ed08:

Fixed #26674 -- Corrected a i18n makemessages test.

Made it consistently read the PO file, decode its contents and then
check for the non-breaking space Unicode code point.

Previously we were erroneously skipping the interpretation of what we
read as UTF-8 text.

This was causing the test to fail on Windows with Python 3.5.

comment:5 by Tim Graham <timograham@…>, 8 years ago

In af8ac46:

[1.10.x] Fixed #26674 -- Corrected a i18n makemessages test.

Made it consistently read the PO file, decode its contents and then
check for the non-breaking space Unicode code point.

Previously we were erroneously skipping the interpretation of what we
read as UTF-8 text.

This was causing the test to fail on Windows with Python 3.5.

Backport of 1b00ed088073ffd268af15d25246d2565253536d from master

Note: See TracTickets for help on using tickets.
Back to Top