Opened 8 years ago

Last modified 20 months ago

#26661 new Cleanup/optimization

Why not using AppConfig's name attribute instead of app_name in urls.py?

Reported by: john-bonachon Owned by: nobody
Component: Core (URLs) Version: 1.9
Severity: Normal Keywords:
Cc: Marten Kenbeek Triage Stage: Accepted
Has patch: no Needs documentation: no
Needs tests: no Patch needs improvement: no
Easy pickings: no UI/UX: no

Description

In Django 1.9 you can namespace your urls by adding app_name in urls.py

If the name will (generally) be the same as the containing module app, why not just call it like that, or at least reusing the AppConfig name attribute from apps.py?

Am I missing something? That's confusing when you are reading the tutorial for the first time.

Change History (6)

comment:1 by Tim Graham, 8 years ago

Cc: Marten Kenbeek added

I seems to remember discussing this during the development of this feature (#21927) but I'm not certain. Marten, do you recall?

comment:2 by Tim Graham, 8 years ago

Component: Core (Other)Core (URLs)
Triage Stage: UnreviewedAccepted
Type: UncategorizedCleanup/optimization

We might end up changing the ticket to a documentation issue to explain the design.

in reply to:  2 comment:3 by john-bonachon, 8 years ago

Replying to timgraham:

We might end up changing the ticket to a documentation issue to explain the design.

Oh.. no interest in reusing the app name?

comment:4 by Tim Graham, 8 years ago

I said "might" because I cannot recall the original design discussion and say for certain whether or not the idea is a good one or is feasible to implement.

comment:5 by Carlton Gibson, 22 months ago

Closed #33774 as a duplicate: Where/how is the application namespace defined?.

We might end up changing the ticket to a documentation issue to explain the design.

Folks do get confused over namespaces, so a documentation review would likely help.

comment:6 by Michael, 20 months ago

I would just like to add its really confusing to call the url namespace attribute app_name, which is associated with the AppConfig.name, the same as how one uses app_name in the context of working with models. This inconsistency creates a false assumption to one trying to learn how this machinery works.

I recommend a different name, something like url_namespace, that would be explicit, and self evident.

Last edited 20 months ago by Michael (previous) (diff)
Note: See TracTickets for help on using tickets.
Back to Top