Opened 9 years ago

Closed 8 years ago

#26651 closed Cleanup/optimization (fixed)

Keep uploaded file suffix for TemporaryUploadedFile

Reported by: Claude Paroz Owned by: nobody
Component: File uploads/storage Version: dev
Severity: Normal Keywords:
Cc: Michael Axiak Triage Stage: Ready for checkin
Has patch: yes Needs documentation: no
Needs tests: no Patch needs improvement: no
Easy pickings: no UI/UX: no

Description

I have a use case where checking a temporary uploaded file (TemporaryUploadedFile.temporary_file_path()) includes a check of its extension. Currently, TemporaryUploadedFile always set .upload as a suffix. Would setting the same suffix as the original uploaded file extension be an issue (security?, compatibility?).

Change History (5)

comment:1 by Tim Graham, 9 years ago

Cc: Michael Axiak added
Component: Core (Other) → File uploads/storage

Michael, it looks like you may have been involved in the original design of this (ticket:2070#comment:129). Do you have any thoughts?

comment:2 by Tim Graham, 9 years ago

Triage Stage: Unreviewed → Someday/Maybe

comment:3 by Claude Paroz, 8 years ago

Has patch: set

​PR

comment:4 by Tim Graham, 8 years ago

Triage Stage: Someday/Maybe → Ready for checkin

We can give that a try and see if any compatibility issues are reported.

comment:5 by Claude Paroz <claude@…>, 8 years ago

Resolution: → fixed
Status: new → closed

In 6352d06c:

Fixed #26651 -- Kept original file suffix in TemporaryUploadedFile name

Thanks Tim Graham for the review.

Note: See TracTickets for help on using tickets.
Back to Top