Opened 17 months ago

Last modified 17 months ago

#26619 new Bug

BaseCache incr method will reset the timeout

Reported by: Esteban Castro Borsani Owned by: nobody
Component: Core (Cache system) Version: 1.8
Severity: Normal Keywords: cache, incr, DatabaseCache, BaseCache
Cc: Triage Stage: Accepted
Has patch: no Needs documentation: no
Needs tests: no Patch needs improvement: no
Easy pickings: no UI/UX: no

Description

BaseCache.incr() resets the timeout to the default timeout. DatabaseCache and FileBasedCache are affected by this, since they do not override the method. I'm not sure what the memcache behaviour is.

To reproduce this, set the default cache backend to django.core.cache.backends.db.DatabaseCache and call incr() on the cache. Although, the bug is easy to spot since .set(...) is being called without passing a timeout.

I'm assuming this is a bug since LocMemCache doesn't reset the timeout, the docs don't mention anything about it and it seems like a surprising behaviour to me.

Django 1.8 and 1.9 are affected by this.

Change History (3)

comment:1 Changed 17 months ago by Tim Graham

I guess a possible resolution would be to add a timeout argument to those methods? I don't think we can increment/ decrement them while keeping the current timeout?

comment:2 Changed 17 months ago by Esteban Castro Borsani

Honestly, I'm not sure. Your proposal is consistent with set(). However, memcached and Redis don't set a timeout when incr/decr. I don't know of a in-memory cache that does that.

The database backend could just update instead of doing a get/set, so it could keep the timeout (and also be atomic), not sure why it was not implemented that way. The filecache backend can also leave the timeout untouched, AFAICT.

If I were to design the cache system from scratch I'd just raise NotImplementedError within the incr/decr of the base backend. But at this point, I don't know how many third-party libs that would break.

comment:3 Changed 17 months ago by Tim Graham

Triage Stage: UnreviewedAccepted

Some discussion on the DevelopersMailingList may be useful to decide on how to proceed.

Note: See TracTickets for help on using tickets.
Back to Top