[patch] Add carriage return quote in django.utils.text.javascript_quote

[Alex Dedul]

\r should be also quoted, at least firefox interprets it as a new line and this breaks javascript. Patch is trivial

Index: django/utils/text.py
===================================================================
--- django/utils/text.py    (revision 3722)
+++ django/utils/text.py    (working copy)
@@ -104,6 +104,7 @@
     elif type(s) != unicode:
         raise TypeError, s
     s = s.replace('\\', '\\\\')
+    s = s.replace('\r', '\\r')
     s = s.replace('\n', '\\n')
     s = s.replace('\t', '\\t')
     s = s.replace("'", "\\'")

[Alex Dedul]

And one more - double quotes should be also quoted as " like this

    s = s.replace('"', '"')

[Alex Dedul]

About double quotes - there could be 2 cases when javascript is embedded in tag's attribute like <a onclick="js_func(...)"> double quotes should be quoted and when it appears in <script></script> or in separate file there is no need to quote. Django now uses the latter in i18n so double quotes can be ignored, but javascript_quote can be made to work for both cases what will allow apps with case N1 utilize it and maybe django itself in the future. Proposed final patch is in attach.

[Malcolm Tredinnick]

(In [3782]) Fixed #2657 -- Made some tweaks to Javascript quoting. Thanks, Alex Dedul.