Opened 9 years ago

Closed 9 years ago

#26553 closed Cleanup/optimization (fixed)

Seemingly redundant outer loop in views/i18n.py

Reported by: Mark Shannon Owned by: nobody
Component: Internationalization Version: dev
Severity: Normal Keywords:
Cc: Triage Stage: Ready for checkin
Has patch: yes Needs documentation: no
Needs tests: no Patch needs improvement: no
Easy pickings: yes UI/UX: no

Description

The outer loop here:
https://github.com/django/django/blob/master/django/views/i18n.py#L78
seems to be redundant.
The final value of result will be unchanged after the first iteration.

Change History (3)

comment:1 by Claude Paroz, 9 years ago

Component: UncategorizedInternationalization
Easy pickings: set
Triage Stage: UnreviewedAccepted
Type: UncategorizedCleanup/optimization
Version: 1.9master

Absolutely, see commit [d44fb0557a0a9d8fab62b] to understand what happened.

comment:2 by Tim Graham, 9 years ago

Has patch: set
Triage Stage: AcceptedReady for checkin

comment:3 by Tim Graham <timograham@…>, 9 years ago

Resolution: fixed
Status: newclosed

In 0d8b523:

Fixed #26553 -- Removed unneeded loop in views/i18n.py

Note: See TracTickets for help on using tickets.
Back to Top