Opened 7 years ago

Closed 7 years ago

Last modified 7 years ago

#26544 closed Bug (fixed)

SetPasswordForm help_text always uses LANGUAGE_CODE as locale

Reported by: Michael Bitzi Owned by: nobody
Component: contrib.auth Version: 1.9
Severity: Normal Keywords:
Cc: Triage Stage: Ready for checkin
Has patch: yes Needs documentation: no
Needs tests: no Patch needs improvement: no
Easy pickings: no UI/UX: no

Description

The SetPasswordForm uses help_text=password_validation.password_validators_help_text_html(), however it will only translate to the LANGUAGE_CODE setting and not to the users language.

I am not very familiar with django internals, but a workaround of help_text=lazy(password_validation.password_validators_help_text_html) seemed to work for me.

Attachments (1)

django-setpasswordform-helptext.png​ (36.9 KB) - added by Michael Bitzi 7 years ago.
SetPasswordForm

Download all attachments as: .zip

Change History (6)

Changed 7 years ago by Michael Bitzi

Attachment: django-setpasswordform-helptext.png​ added

SetPasswordForm

comment:1 Changed 7 years ago by Tim Graham

Triage Stage: Unreviewed → Accepted

comment:2 Changed 7 years ago by Claude Paroz

Has patch: set

​PR

comment:3 Changed 7 years ago by Tim Graham

Triage Stage: Accepted → Ready for checkin

comment:4 Changed 7 years ago by Claude Paroz <claude@…>

Resolution: → fixed
Status: new → closed

In b26fedac:

Fixed #26544 -- Delayed translations of SetPasswordForm help_texts

Thanks Michael Bitzi for the reporti and Tim Graham for the review.

comment:5 Changed 7 years ago by Claude Paroz <claude@…>

In 669b8e3d:

[1.9.x] Fixed #26544 -- Delayed translations of SetPasswordForm help_texts

Thanks Michael Bitzi for the reporti and Tim Graham for the review.
Backport of b26fedacef from master.

Note: See TracTickets for help on using tickets.
Back to Top