Opened 8 years ago

Closed 8 years ago

#26542 closed Bug (fixed)

Extension names are not properly quoted in the PostgreSQL CreateExtension operation

Reported by: Conrad Kramer Owned by: Tim Graham <timograham@…>
Component: contrib.postgres Version: 1.9
Severity: Normal Keywords:
Cc: Triage Stage: Ready for checkin
Has patch: yes Needs documentation: no
Needs tests: no Patch needs improvement: no
Easy pickings: no UI/UX: no

Description

Running CreateExtension('uuid-ossp') in the current version of Django fails with a Postgres syntax error.

Attachments (1)

26542.diff​ (1.6 KB) - added by Conrad Kramer 8 years ago.

Download all attachments as: .zip

Change History (7)

Changed 8 years ago by Conrad Kramer

Attachment: 26542.diff​ added

comment:1 Changed 8 years ago by Conrad Kramer

comment:2 Changed 8 years ago by Simon Charette

Triage Stage: Unreviewed → Accepted

comment:3 Changed 8 years ago by Claude Paroz

Conrad, would you be able to propose your patch as a pull request on Github?
I think you could improve it a bit by using the quote_name method instead of literal quotes.

comment:4 Changed 8 years ago by Conrad Kramer

I went ahead and made the suggested change and proposed it as a ​pull request on Github.

Let me know if there are any other changes I should make!

comment:5 Changed 8 years ago by Claude Paroz

Triage Stage: Accepted → Ready for checkin

comment:6 Changed 8 years ago by Tim Graham <timograham@…>

Owner: set to Tim Graham <timograham@…>
Resolution: → fixed
Status: new → closed

In c112198:

Fixed #26542 -- Fixed quoting in CreateExtension operation.

Note: See TracTickets for help on using tickets.
Back to Top