Changes between Version 2 and Version 10 of Ticket #26520


Ignore:
Timestamp:
Apr 20, 2016, 11:54:29 AM (8 years ago)
Author:
Tim Graham
Comment:

Legend:

Unmodified
Added
Removed
Modified

  • Ticket #26520

    • Property Severity Normal → Release blocker
    • Property Triage Stage Unreviewed → Ready for checkin
    • Property Summary Undo #24621 to make session.pop raise a KeyError again → SessionBase.pop() no longer raises a KeyError

  • Ticket #26520 – Description

    v2 v10  
    1 The fix of https://code.djangoproject.com/ticket/24621 led to always providing a default to session's dict method pop. This prevents a KeyError to ever be thrown, which should be expected by a pop-function.
     1The fix of #24621 led to always providing a `default` to session's dict's `pop()` method. This prevents a `KeyError` from ever being raised, which should be expected by a pop-function.
    22
    33Pull request is https://github.com/django/django/pull/6480
Back to Top