Opened 3 years ago

Last modified 3 years ago

#26520 closed Bug

Undo #24621 to make session.pop raise a KeyError again — at Version 2

Reported by: Tobias Krönke Owned by: nobody
Component: contrib.sessions Version: 1.9
Severity: Release blocker Keywords:
Cc: Triage Stage: Ready for checkin
Has patch: yes Needs documentation: no
Needs tests: no Patch needs improvement: no
Easy pickings: yes UI/UX: no

Description (last modified by Tobias Krönke)

The fix of https://code.djangoproject.com/ticket/24621 led to always providing a default to session's dict method pop. This prevents a KeyError to ever be thrown, which should be expected by a pop-function.

Pull request is https://github.com/django/django/pull/6480

Change History (2)

comment:1 Changed 3 years ago by Tobias Krönke

comment:2 Changed 3 years ago by Tobias Krönke

Description: modified (diff)
Note: See TracTickets for help on using tickets.
Back to Top