XML Serialization of None TextFields does not use the <None/> tag

[ben.khoo@…]

There appears to be a problem serializing TextFields where the value is None.

Refer to line 62 of xml_serializer.py
The expected return value from self.get_string_value(obj, field) is either a string or None however the get_string_value method does not appear to return None when appropriate.

The result of this oversight is that TextFields where the value is None is encoded as

<field type="TextField" name="comment">None</field>

rather than

<field type="TextField" name="comment">
<None/>
</field>

[ben.khoo@…]

A potential patch

[ben.khoo@…]

Modification to the XML serializer to correctly encode the tag

[Malcolm Tredinnick]

Please attach a patch against the current source, rather than the whole files. It is very difficult to work out what places you made changes to in both these files.

From what I can work out from your changes, I'm not sure it is correct. Can you please attach a test case showing that we deserialize the object correctly after making the change you propose. There might be a change needed in deserialization as well.

Removing the patch keyword for now until there is a real patch available.