Should reusable django apps use `zip_safe=False` in setup.py?

[Thomas Güttler]

I am unsure whether zip_safe=False is needed in setup.py for reusable apps.

Here is my question on StackOverflow:

​http://stackoverflow.com/questions/36403429/should-reusable-django-apps-use-zip-safe-false-in-setup-py

According to the answer zip_safe=False should be used.

The current docs don't contain this key-value pair in setup.py:

​https://docs.djangoproject.com/en/1.9/intro/reusable-apps/

I am stupid, please show me the sane and default way in the docs :-)

[Tim Graham]

I think it's not strictly needed as setuptools ​seems to have some autodetection. I guess I'm concerned that adding it without any comment or explanation will cause readers to copy and paste it in their own projects without understanding the ramifications (e.g. projects without templates, static files, or similar assets may not need it, I think).

I'm not sure if Django's docs are the place for education about setuptools options like this. Any opinions?

[Claude Paroz]

I think we can add it with a comment in the docs.

[Hynek Cernoch]

This was important until Django 1.7.11 and fixed in Django 1.8. It is fortunatily too late to do anything and also application developers can forget slowly about it from the point of view backward compatibility. (I am author of the quoted answer. I have tested both versions now when I know about this ticket.)

[Thomas Güttler]

Replying to hynekcer:

This was important until Django 1.7.11 and fixed in Django 1.8. It is fortunatily too late to do anything and also application developers can forget slowly about it from the point of view backward compatibility. (I am author of the quoted answer. I have tested both versions now when I know about this ticket.)

Thank you very much. If other people still use the old version, then they should find this issue and they have all they need.

I close this issue since it does not apply to current django verions any more. Thank you for all people involved.