Opened 10 years ago

Closed 10 years ago

Last modified 10 years ago

#26477 closed Bug (fixed)

Docs: Example about bookmarks mentions books

Reported by: Mikkel Munch Mortensen Owned by: nobody
Component: Documentation Version: dev
Severity: Normal Keywords:
Cc: Triage Stage: Unreviewed
Has patch: yes Needs documentation: no
Needs tests: no Patch needs improvement: no
Easy pickings: yes UI/UX: no

Description

In the docs about the contenttypes framework, there's an example of using related_query_name for GenericRelation. In the second part of the code example, the comment says:

Get all tags belonging to books containing `django` in the url

But the example is about bookmarks, not books.

https://github.com/django/django/blob/ecb59cc6579402b68ddfd4499bf30edacf5963be/docs/ref/contrib/contenttypes.txt#L386-L396

I have attached a patch for this. I'd be happy to provide it via a pull request on GitHub, if that is a better of contributing a tiny fix like this.

Attachments (1)

contenttypes-docs-fix.patch (1.1 KB ) - added by Mikkel Munch Mortensen 10 years ago.
A patch to replace "books" with "bookmarks"

Download all attachments as: .zip

Change History (6)

by Mikkel Munch Mortensen, 10 years ago

Attachment: contenttypes-docs-fix.patch added

A patch to replace "books" with "bookmarks"

comment:1 by Mikkel Munch Mortensen, 10 years ago

Sorry for unsetting these. It happened while trying to set the "has patch" flag.

Last edited 10 years ago by Mikkel Munch Mortensen (previous) (diff)

comment:2 by Mikkel Munch Mortensen, 10 years ago

Has patch: set

comment:3 by Tim Graham <timograham@…>, 10 years ago

Resolution: fixed
Status: newclosed

In 92d77f31:

[1.9.x] Fixed #26477 -- Fixed typo in docs/ref/contrib/contenttypes.txt

Backport of 4bb3ddbcc674601743c63311d7efbf0e1fd19742 from master

comment:4 by Tim Graham <timograham@…>, 10 years ago

In 4bb3ddbc:

Fixed #26477 -- Fixed typo in docs/ref/contrib/contenttypes.txt

comment:5 by Tim Graham <timograham@…>, 10 years ago

In 7c67508a:

[1.8.x] Fixed #26477 -- Fixed typo in docs/ref/contrib/contenttypes.txt

Backport of 4bb3ddbcc674601743c63311d7efbf0e1fd19742 from master

Note: See TracTickets for help on using tickets.
Back to Top