#26474 closed Cleanup/optimization (fixed)

Add source of minified javascript files

Reported by: Raphaël Hertzog Owned by: Pyie Zone
Component: Packaging Version: 1.9
Severity: Normal Keywords:
Cc: Triage Stage: Accepted
Has patch: no Needs documentation: no
Needs tests: no Patch needs improvement: no
Easy pickings: no UI/UX: no

Description

In Debian, we like to have the sources of everything that we ship and we consider that minified javascript files are not really scripts (which are their own source).

There are currently two problematic files in Django:
js_tests/qunit/blanket.min.js
django/contrib/admin/static/admin/js/vendor/xregexp/xregexp.min.js

To remedy this I would suggest to either:

  • directly use a non-minified file like you do for many other javascript files (ex: django/contrib/admin/static/admin/js/SelectFilter2.js)
  • store a non-minified file next to the minified file (same name without the ".min" part)

Thank you for considering this request.

Change History (11)

comment:1 Changed 20 months ago by Tim Graham

I've asked for thoughts about this on the django-developers mailing list.

comment:2 Changed 20 months ago by Tim Graham

Component: UncategorizedPackaging
Triage Stage: UnreviewedAccepted

We can add the non-minified versions I guess. This would also include modifying django/contrib/admin/options.py to use extra in vendor/xregexp/xregexp.min.js.

comment:3 Changed 18 months ago by Pyie Zone

Owner: changed from nobody to Pyie Zone
Status: newassigned

comment:4 Changed 18 months ago by Pyie Zone

I've created PR 6724

The added source file xregexp.js did not pass js check. It was downloaded directly from the original repo. I am not familiar with the process. Am I supposed to update the source js file to make it pass? Thanks!

comment:5 Changed 18 months ago by Tim Graham <timograham@…>

In 054e7442:

Refs #16501, #26474 -- Added xregexp.js source file.

comment:6 Changed 18 months ago by Tim Graham <timograham@…>

In 8f8dc830:

Refs #26474, DEP 0003 -- Added blanket.js source file.

comment:7 Changed 18 months ago by Tim Graham <timograham@…>

In ef93af91:

[1.10.x] Refs #16501, #26474 -- Added xregexp.js source file.

Backport of 054e74420b7a31bac67d4993b462eea7b9b7a5ba from master

comment:8 Changed 18 months ago by Tim Graham <timograham@…>

In a9b0b07:

[1.10.x] Refs #26474, DEP 0003 -- Added blanket.js source file.

Backport of 8f8dc830dfeb321b0de3325a8d2c859fdc20c3af from master

comment:9 Changed 18 months ago by Tim Graham <timograham@…>

In 36b9e4a:

[1.9.x] Refs #26474, DEP 0003 -- Added blanket.js source file.

Backport of 8f8dc830dfeb321b0de3325a8d2c859fdc20c3af from master

comment:10 Changed 18 months ago by Tim Graham <timograham@…>

In 307de7d9:

[1.9.x] Refs #16501, #26474 -- Added xregexp.js source file.

Backport of 054e74420b7a31bac67d4993b462eea7b9b7a5ba from master

comment:11 Changed 18 months ago by Tim Graham

Resolution: fixed
Status: assignedclosed
Note: See TracTickets for help on using tickets.
Back to Top