Opened 10 years ago

Closed 10 years ago

#26460 closed Cleanup/optimization (fixed)

Don't call ``warnings.warn`` for each invalid character in a caching key

Reported by: Przemysław Suliga Owned by: nobody
Component: Core (Cache system) Version: dev
Severity: Normal Keywords:
Cc: Triage Stage: Ready for checkin
Has patch: yes Needs documentation: no
Needs tests: no Patch needs improvement: no
Easy pickings: no UI/UX: no

Description (last modified by Przemysław Suliga)

BaseCache.validate_key() will call warnings.warn() ​for each invalid character in the key. This is not a big issue since only one warning will appear but it is unnecessary.

Fixed in ​https://github.com/django/django/pull/6414

Change History (3)

comment:1 by Przemysław Suliga, 10 years ago

Description: modified (diff)

comment:2 by Simon Charette, 10 years ago

Component: Uncategorized → Core (Cache system)
Triage Stage: Unreviewed → Ready for checkin
Type: Uncategorized → Cleanup/optimization
Version: 1.9 → master

comment:3 by Simon Charette <charettes@…>, 10 years ago

Resolution: → fixed
Status: new → closed

In d356bb6:

Fixed #26460 -- Issued a single warning for invalid cache key

Note: See TracTickets for help on using tickets.
Back to Top