Opened 8 years ago

Closed 8 years ago

Last modified 8 years ago

#26450 closed Bug (fixed)

Docs says label is "Save as" for the button that actually has the label "Save as new"

Reported by: Markus Amalthea Magnuson Owned by: Markus Amalthea Magnuson
Component: Documentation Version: 1.9
Severity: Normal Keywords:
Cc: Triage Stage: Ready for checkin
Has patch: yes Needs documentation: no
Needs tests: no Patch needs improvement: no
Easy pickings: no UI/UX: no

Description

The documentation for the save_as option on ModelAdmin says the button is labeled "Save as" while in fact it is labeled "Save as new":

If save_as is True, “Save and add another” will be replaced by a “Save as” button.

​https://docs.djangoproject.com/en/1.9/ref/contrib/admin/#django.contrib.admin.ModelAdmin.save_as

I guess this changed at some point and the docs were not updated at the same time (can't find a ticket for that change at the moment.)

The docs should be updated to reflect the correct button label in at least 1.9. I will open a pull request for this.

Change History (5)

comment:1 by Markus Amalthea Magnuson, 8 years ago

Owner: changed from nobody to Markus Amalthea Magnuson
Status: new → assigned

comment:2 by Markus Amalthea Magnuson, 8 years ago

Has patch: set

Pull request is here: ​https://github.com/django/django/pull/6396

comment:3 by Anna Schneider, 8 years ago

Triage Stage: Unreviewed → Ready for checkin

comment:4 by Tim Graham <timograham@…>, 8 years ago

Resolution: → fixed
Status: assigned → closed

In 23aa700:

Fixed #26450 -- Corrected "Save as new" button label in docs.

comment:5 by Tim Graham <timograham@…>, 8 years ago

In dd1ab149:

[1.9.x] Fixed #26450 -- Corrected "Save as new" button label in docs.

Backport of 23aa700b788e073e6efc4585425c0bd6d3092569 from master

Note: See TracTickets for help on using tickets.
Back to Top