Opened 10 years ago

Last modified 8 years ago

#26447 closed Cleanup/optimization

Deprecate USE_ETAGS setting in favor of ConditionalGetMiddleware unconditionally setting an ETag — at Version 4

Reported by: Denis Cornehl Owned by: Denis Cornehl
Component: HTTP handling Version: 1.9
Severity: Normal Keywords:
Cc: k@… Triage Stage: Ready for checkin
Has patch: yes Needs documentation: no
Needs tests: no Patch needs improvement: no
Easy pickings: no UI/UX: no

Description (last modified by Tim Graham)

In my opinion this setting is not needed (any more)

  • Conditional-Get handling can happen in the ConditionalGetMiddleware, not in CommonMiddleware any more
  • using or not using the middleware is (nearly) the same as setting USE_ETAGS or not
  • ETag Calculation can happen also in the middleware

this also will fix a problem when you use the GZipMiddleware in combination with the Conditional-Get handling in CommonMiddleware.

Open questions for me:

  • ConditionalGetMiddleware also handles Last-Modified/If-Modified-Since , which CommonMiddleware didn't. I don't see a problem in throwing them together and activating/deactivating them together. You?

Change History (4)

comment:1 by Denis Cornehl, 10 years ago

Has patch: set
Triage Stage: Unreviewed → Accepted

(after some discussions here at the DjangoCon springs I've just set the triage state :) )

comment:2 by Tim Graham, 10 years ago

Patch needs improvement: set

Left comments for improvement on the ​PR.

comment:3 by Tim Graham, 9 years ago

Component: Uncategorized → HTTP handling

comment:4 by Tim Graham, 9 years ago

Description: modified (diff)
Patch needs improvement: unset
Summary: Remove USE_ETAGS setting → Deprecate USE_ETAGS setting in favor of ConditionalGetMiddleware unconditionally setting an ETag

​Updated PR

Note: See TracTickets for help on using tickets.
Back to Top