Opened 8 years ago
Last modified 6 years ago
#26447 closed Cleanup/optimization
Remove USE_ETAGS setting — at Initial Version
| Reported by: | Denis Cornehl | Owned by: | Denis Cornehl |
|---|---|---|---|
| Component: | HTTP handling | Version: | 1.9 |
| Severity: | Normal | Keywords: | |
| Cc: | k@… | Triage Stage: | Ready for checkin |
| Has patch: | yes | Needs documentation: | no |
| Needs tests: | no | Patch needs improvement: | no |
| Easy pickings: | no | UI/UX: | no |
Description
(with deprecation)
In my opinion this setting is not needed (any more)
- Conditional-Get handling can happen in the ConditionalGetMiddleware, not in CommonMiddleware any more
- using or not using the middleware is (nearly) the same as setting USE_ETAGS or not
- ETag Calculation can happen also in the middleware
this also will fix a problem when you use the GZipMiddleware in combination with the Conditional-Get handling in CommonMiddleware.
Open questions for me:
- ConditionalGetMiddleware also handles Last-Modified/If-Modified-Since , which CommonMiddleware didn't. I don't see a problem in throwing them together and activating/deactivating them together. You?
Note:
See TracTickets
for help on using tickets.