Opened 9 years ago
Closed 9 years ago
#26421 closed Cleanup/optimization (fixed)
ModelSignal should use Apps.lazy_model_operation
Reported by: | Alex Hill | Owned by: | nobody |
---|---|---|---|
Component: | Database layer (models, ORM) | Version: | dev |
Severity: | Normal | Keywords: | |
Cc: | Triage Stage: | Accepted | |
Has patch: | yes | Needs documentation: | no |
Needs tests: | no | Patch needs improvement: | no |
Easy pickings: | no | UI/UX: | no |
Description
ModelSignal
s currently have their own mechanism for resolving model strings. For consistency and simplicity they should probably just use the mechanism provided by Apps
.
Change History (8)
comment:1 by , 9 years ago
Patch needs improvement: | set |
---|---|
Triage Stage: | Unreviewed → Accepted |
comment:2 by , 9 years ago
I couldn't replicate the failures under 2.7 on my machine. I think this bug was being triggered (partial.keywords
sometimes being None
instead of an empty dictionary): https://mail.python.org/pipermail/python-checkins/2016-February/141212.html
I've updated the patch with a workaround and everything's green now.
comment:3 by , 9 years ago
Patch needs improvement: | unset |
---|
comment:4 by , 9 years ago
Triage Stage: | Accepted → Ready for checkin |
---|
comment:5 by , 9 years ago
Patch needs improvement: | set |
---|---|
Triage Stage: | Ready for checkin → Accepted |
Left a few comments for improvement.
comment:6 by , 9 years ago
Patch needs improvement: | unset |
---|
Tests aren't passing on Python 2.