Opened 8 years ago

Closed 8 years ago

#26421 closed Cleanup/optimization (fixed)

ModelSignal should use Apps.lazy_model_operation

Reported by: Alex Hill Owned by: nobody
Component: Database layer (models, ORM) Version: dev
Severity: Normal Keywords:
Cc: Triage Stage: Accepted
Has patch: yes Needs documentation: no
Needs tests: no Patch needs improvement: no
Easy pickings: no UI/UX: no

Description

ModelSignals currently have their own mechanism for resolving model strings. For consistency and simplicity they should probably just use the mechanism provided by Apps.

PR: ​https://github.com/django/django/pull/6359

Change History (8)

comment:1 by Tim Graham, 8 years ago

Patch needs improvement: set
Triage Stage: Unreviewed → Accepted

Tests aren't passing on Python 2.

comment:2 by Alex Hill, 8 years ago

I couldn't replicate the failures under 2.7 on my machine. I think this bug was being triggered (partial.keywords sometimes being None instead of an empty dictionary): ​https://mail.python.org/pipermail/python-checkins/2016-February/141212.html

I've updated the patch with a workaround and everything's green now.

comment:3 by Tim Graham, 8 years ago

Patch needs improvement: unset

comment:4 by Simon Charette, 8 years ago

Triage Stage: Accepted → Ready for checkin

comment:5 by Tim Graham, 8 years ago

Patch needs improvement: set
Triage Stage: Ready for checkin → Accepted

Left a few comments for improvement.

comment:6 by Tim Graham, 8 years ago

Patch needs improvement: unset

comment:7 by Tim Graham <timograham@…>, 8 years ago

In 2ff7ef15:

Refs #26421 -- Refactored Apps.lazy_model_operation() for better checks and tests

comment:8 by Tim Graham <timograham@…>, 8 years ago

Resolution: → fixed
Status: new → closed

In 779bb82f:

Fixed #26421 -- Refactored ModelSignal to use Apps.lazy_model_operation()

Note: See TracTickets for help on using tickets.
Back to Top