None

[hugo <gb@…>]

IP addresses are quite custom values so I think creating a validator for that type would be justified. Here is my take at the problem:

import re

IP = re.compile('^\d+\.\d+\.\d+\.\d+$')
def isIPAddress(field_data, all_data):
    if IP.match(field_data):
        parts = [0 <= int(el) <= 255 for el in field_data.split('.')]
        if len(parts) == 4: return
    raise validators.ValidationError("Please enter a dotted number notation for an IP address")

[hugo <gb@…>]

As pointed out, this is only an IPv4 address validator.

[Simon Willison]

There is a bug in your code: it will flag "99.99.99.99" as valid - parts will be [False, False, False, False] but the length of that list is still 4. The fix is to do this:

parts = [el for el in field_data.split('.') if 0 <= int(el) <= 255]

I would suggest renaming "parts" to "valid_parts" to make the code more clear - also, "IP" should be "ip_re" for consistency with the other validators. Here's an updated version of the validator:

import re

ip_re = re.compile('^\d{1,3}\.\d{1,3}\.\d{1,3}\.\d{1,3}$')

def isIPAddress(field_data, all_data):
    if ip_re.match(field_data):
        valid_parts = [el for el in field_data.split('.') if 0 <= int(el) <= 255]
        if len(valid_parts) == 4:
            return True
        raise validators.ValidationError("Please enter a dotted number notation for an IP address")

[Adrian Holovaty]

Fixed in [671].

[anonymous]

semi truck driving jobs truck driving jobs in ohio