Opened 8 years ago

Closed 8 years ago

Last modified 8 years ago

#26375 closed Cleanup/optimization (fixed)

Docs: since author_form.html gets used by CreateView and UpdateView, the button should be be called "Create"

Reported by: Thomas Güttler Owned by: nobody
Component: Documentation Version: 1.9
Severity: Normal Keywords:
Cc: Triage Stage: Unreviewed
Has patch: no Needs documentation: no
Needs tests: no Patch needs improvement: no
Easy pickings: no UI/UX: no

Description

https://docs.djangoproject.com/en/1.9/ref/class-based-views/generic-editing/#createview

The author_form.html snippet from above url:

<form action="" method="post">{% csrf_token %}
    {{ form.as_p }}
    <input type="submit" value="Create" />
</form>

From this page https://docs.djangoproject.com/en/1.9/topics/class-based-views/generic-editing/:

CreateView and UpdateView use myapp/author_form.html

Conclusion: the button should not be called "Create". Maybe "Save" would fit better.

Change History (3)

comment:1 by Tim Graham <timograham@…>, 8 years ago

Resolution: fixed
Status: newclosed

In 1d0abea:

Fixed #26375 -- Used a more generic name in a reusable template example.

comment:2 by Tim Graham <timograham@…>, 8 years ago

In 56f50592:

[1.8.x] Fixed #26375 -- Used a more generic name in a reusable template example.

Backport of 1d0abeaf757518808aabe9c85a2beaaa340fbc43 from master

comment:3 by Tim Graham <timograham@…>, 8 years ago

In f6f24af1:

[1.9.x] Fixed #26375 -- Used a more generic name in a reusable template example.

Backport of 1d0abeaf757518808aabe9c85a2beaaa340fbc43 from master

Note: See TracTickets for help on using tickets.
Back to Top