Opened 8 years ago
Last modified 8 years ago
#26328 closed Bug
jsi18n - get_javascript_catalog obscure and hardcoded english — at Version 1
| Reported by: | Cristiano Coelho | Owned by: | nobody |
|---|---|---|---|
| Component: | Internationalization | Version: | 1.9 |
| Severity: | Normal | Keywords: | jsi18n |
| Cc: | cristianocca@…, Claude Paroz | Triage Stage: | Ready for checkin |
| Has patch: | yes | Needs documentation: | no |
| Needs tests: | no | Patch needs improvement: | no |
| Easy pickings: | no | UI/UX: | no |
Description (last modified by )
This is a ticket to get some support in removing the actual hardcoded english fallback (even if default language is not english) in get_javascript_catalog.
Discussion here: https://groups.google.com/forum/#!topic/django-developers/gDU8HlZg4Ug
But basically, the current jsi18n will always load english as a fallback language, which will be then overriten by what ever your default language is, but may cause some issues if you don't want to add message strings to your default language (because ids == values) and you end up with english translations.
The proposed change is to remove this english loading completely, and only load the default language as fallback, which will then match the server side behaviour for translations where the above is not an issue.
Please submit a tested pull requested. I removed the code from the patch's description since I don't think anyone will review it there (not to mention, we cannot easily tell what changed).
I'm not sure what you're trying to say by describing the function as "obscure" in the ticket summary. Could you try to rephrase it to describe the desired changes?
Finally, if English fallbacks aren't loaded anymore, couldn't this be backwards-incompatible for some user? (keep in mind, I don't have any experience with this code so maybe there's no problem)