Opened 7 years ago

Closed 7 years ago

Last modified 7 years ago

#26286 closed Bug (fixed)

Content type managers instances shouldn't share their cache.

Reported by: Simon Charette Owned by: nobody
Component: contrib.contenttypes Version: 1.8
Severity: Release blocker Keywords:
Cc: Triage Stage: Accepted
Has patch: yes Needs documentation: no
Needs tests: no Patch needs improvement: no
Easy pickings: no UI/UX: no

Description

Now that ContentTypeManager instances are used in migrations (#23822) they shouldn't share their underlying _cache as they might be bound to ContentType models from different apps.

This is bug I discovered while working on #24067 which development stalled because it needed more thought.

Change History (7)

comment:1 Changed 7 years ago by Simon Charette

Has patch: set

​PR

comment:2 Changed 7 years ago by Simon Charette

I guess this could be considered a 1.8.x release blocker as it's a bug in a new feature.

comment:3 Changed 7 years ago by Tim Graham

Triage Stage: Accepted → Ready for checkin

comment:4 Changed 7 years ago by Simon Charette

Severity: Normal → Release blocker
Triage Stage: Ready for checkin → Accepted
Version: master → 1.8

Escalated the issue to a release blocker for 1.8.x as it's a bug in a new feature #23822.

Let me know if the release notes make sense.

comment:5 Changed 7 years ago by Simon Charette <charette.s@…>

Resolution: → fixed
Status: new → closed

In 3938b3cc:

Fixed #26286 -- Prevented content type managers from sharing their cache.

This should prevent managers methods from returning content type instances
registered to foreign apps now that these managers are also attached to models
created during migration phases.

Thanks Tim for the review.

Refs #23822.

comment:6 Changed 7 years ago by Simon Charette <charette.s@…>

In ba6f83ec:

[1.9.x] Fixed #26286 -- Prevented content type managers from sharing their cache.

This should prevent managers methods from returning content type instances
registered to foreign apps now that these managers are also attached to models
created during migration phases.

Thanks Tim for the review.

Refs #23822.

Backport of 3938b3ccaa85f1c366909a4839696007726a09da from master

comment:7 Changed 7 years ago by Simon Charette <charette.s@…>

In 4701c81d:

[1.8.x] Fixed #26286 -- Prevented content type managers from sharing their cache.

This should prevent managers methods from returning content type instances
registered to foreign apps now that these managers are also attached to models
created during migration phases.

Thanks Tim for the review.

Refs #23822.

Backport of 3938b3ccaa85f1c366909a4839696007726a09da from master

Note: See TracTickets for help on using tickets.
Back to Top