Opened 19 years ago
Closed 14 years ago
#2626 closed Bug (fixed)
Datetime handling is broken when dealing with more than one time zone
| Reported by: | Tom Tobin | Owned by: | Aymeric Augustin |
|---|---|---|---|
| Component: | Core (Other) | Version: | |
| Severity: | Normal | Keywords: | |
| Cc: | mike.scott@…, nreilly@…, George Song, miracle2k, jedie, Forest Bond, bronger@…, Chris Chambers, Dan Fairs, cg@…, louis30, David Foster | Triage Stage: | Accepted |
| Has patch: | no | Needs documentation: | no |
| Needs tests: | no | Patch needs improvement: | no |
| Easy pickings: | no | UI/UX: | no |
Description (last modified by )
Django doesn't handle multiple time zones well.
Datetimes are potentially stored with a time zone offset based on settings.TIME_ZONE (only for PostgreSQL), and retrieved as naive datetime objects. This is fine when working on a standard site publishing items within a single time zone, but quickly becomes pathological when working with more than one time zone, or when transitioning an existing site to a new time zone.
I propose that Django's datetime handling be altered to ignore settings.TIME_ZONE on all database backends, and let the appropriate Fields handle time zone conversion. I've already written a DateTimeZoneField that appropriately handles multiple time zones and returns timezone-aware datetime objects; for it to work consistently, however, the PostgreSQL backends need to stop using TIMESTAMP WITH TIME ZONE and SET TIME ZONE.
In summary:
1) The PostgreSQL backends should ignore time zones completely.
2) An appropriate Field, rather than a backend, should handle time zone support; such a field would require its backend storage to always be UTC, which can only happen cleanly if the backend ignores time zones.
Discussion thread:
http://groups.google.com/group/django-developers/browse_thread/thread/b8c885389374c040
Change History (34)
comment:1 by , 19 years ago
| Triage Stage: | Unreviewed → Accepted |
|---|
comment:2 by , 18 years ago
| Reporter: | changed from to |
|---|
comment:3 by , 18 years ago
| Owner: | changed from to |
|---|---|
| Status: | new → assigned |
comment:4 by , 18 years ago
| Cc: | added |
|---|
comment:5 by , 18 years ago
| Owner: | removed |
|---|---|
| Status: | assigned → new |
comment:6 by , 18 years ago
| Owner: | set to |
|---|
comment:7 by , 18 years ago
| Cc: | added |
|---|
comment:8 by , 17 years ago
| Description: | modified (diff) |
|---|
comment:9 by , 17 years ago
| Description: | modified (diff) |
|---|
comment:10 by , 17 years ago
| milestone: | → 1.0 |
|---|
comment:11 by , 17 years ago
| milestone: | 1.0 → post-1.0 |
|---|
Please don't change milestones just because you'd like to see something in 1.0.
comment:12 by , 17 years ago
| Cc: | removed |
|---|
comment:14 by , 17 years ago
| Reporter: | changed from to |
|---|
Removing my email from Reporter in hopes that Trac stops emailing me.
comment:15 by , 17 years ago
| Cc: | added |
|---|
comment:16 by , 17 years ago
I only see the SQL element being discussed, however, there is a more general problem where even datetime.now() will (randomly?) report incorrectly.
Using Apache and both mod_python and wsgi I find that various uses of datetime.now() around a project will give another TZ.
comment:19 by , 17 years ago
| Cc: | added |
|---|
comment:20 by , 17 years ago
I want to make sure I have some basic decisions straight before tackling this problem. We want to only affect how datetime.datetime objects behave, and not datetime.time and datetime.date objects, right? In other words, only models.DateTimeField, not models.TimeField and models.DateField. I don't think timezone conversions are meaningful in those cases, at least not generally.
Also when I work on this problem, I will follow my proposal in #10587 unless there's any strong objections.
comment:22 by , 16 years ago
I'm deleting my earlier comment pointing to code at LaunchPad, since The Onion does not currently maintain any available open source code there (or anywhere, at the moment — we're very busy bees).
comment:23 by , 16 years ago
| Cc: | added |
|---|
comment:24 by , 16 years ago
| Cc: | added |
|---|---|
| Owner: | changed from to |
| Status: | new → assigned |
comment:25 by , 16 years ago
| Cc: | added |
|---|
comment:26 by , 15 years ago
| Cc: | added |
|---|
Another very subtle problem arising from this is that conditinal view processing may break. If you read a last-modified model field from a PostgreSQL backend in your last_modified_func and return it, the resulting HTTP header field is incorrect if your timezone isn't GMT. The reason is that the decorator expects a datetime object with correct tzinfo, but the ORM doesn't set this field.
comment:27 by , 15 years ago
| Cc: | added |
|---|
comment:28 by , 15 years ago
| Owner: | changed from to |
|---|---|
| Status: | assigned → new |
comment:29 by , 15 years ago
| Cc: | added |
|---|
comment:31 by , 15 years ago
| Cc: | added |
|---|
comment:32 by , 15 years ago
| Cc: | added |
|---|
comment:33 by , 15 years ago
| Severity: | normal → Normal |
|---|---|
| Type: | defect → Bug |
comment:34 by , 14 years ago
| Easy pickings: | unset |
|---|---|
| Owner: | changed from to |
| UI/UX: | unset |
comment:35 by , 14 years ago
| Cc: | added |
|---|
Go ahead, Tom - write us a patch! Check out #2447 which may be related.
I agree that the
os.environ['TZ']is an ugly hack, there are other related tickets that back this up ;)