Opened 10 years ago
Closed 10 years ago
#26241 closed Uncategorized (worksforme)
collectstatic's output of `skipping x (not modified)` isn't very clear
| Reported by: | Keryn Knight | Owned by: | AMaini503 |
|---|---|---|---|
| Component: | contrib.staticfiles | Version: | dev |
| Severity: | Normal | Keywords: | |
| Cc: | django@…, AMaini503 | Triage Stage: | Unreviewed |
| Has patch: | yes | Needs documentation: | no |
| Needs tests: | no | Patch needs improvement: | no |
| Easy pickings: | yes | UI/UX: | no |
Description
Running manage.py collectstatic gives output like:
Skipping 'img/hello.jpg' (not modified)
Based on that message, it's unclear why the file was skipped. Is it because the contents are the same? A hash collision of the filename, content? Permissions? etc.
It's actually just because the timestamps match, as far as I can tell based on a quick search, which is absolutely fine, but I had to go to the implementation to find out what constituted it being unmodified.
I'd like to suggest that the wording be improved/clarified. Perhaps just something like modified dates are the same (I'm not tied to that wording specifically!).
Attachments (1)
Change History (6)
comment:1 by , 10 years ago
| Owner: | changed from to |
|---|---|
| Status: | new → assigned |
comment:2 by , 10 years ago
| Cc: | added |
|---|---|
| Has patch: | set |
| Type: | New feature → Uncategorized |
by , 10 years ago
| Attachment: | 26241.diff added |
|---|
comment:3 by , 10 years ago
comment:4 by , 10 years ago
As far as I'm concerned, (not modified) seems rather clear (the file has not been modified since last run). I don't find the proposal better.
--> Modified the message as required for more clarity
Line 267 : collectstatic.py (old)
self.log("Skipping '%s' (not modified)" % path)Line 267-269 : collecstatic.py (new)
# Message changed to convey the reason clearly as to why the file was skipped beca # Compares timestamps using --> http_date self.log("Skipping '%s' (Dates of last modification are same)" % path)