Opened 3 years ago

Closed 3 years ago

#26241 closed Uncategorized (worksforme)

collectstatic's output of `skipping x (not modified)` isn't very clear

Reported by: Keryn Knight Owned by: AMaini503
Component: contrib.staticfiles Version: master
Severity: Normal Keywords:
Cc: django@…, AMaini503 Triage Stage: Unreviewed
Has patch: yes Needs documentation: no
Needs tests: no Patch needs improvement: no
Easy pickings: yes UI/UX: no

Description

Running manage.py collectstatic gives output like:

Skipping 'img/hello.jpg' (not modified)

Based on that message, it's unclear why the file was skipped. Is it because the contents are the same? A hash collision of the filename, content? Permissions? etc.

It's actually just because the timestamps match, as far as I can tell based on a quick search, which is absolutely fine, but I had to go to the implementation to find out what constituted it being unmodified.

I'd like to suggest that the wording be improved/clarified. Perhaps just something like modified dates are the same (I'm not tied to that wording specifically!).

Attachments (1)

26241.diff (1.0 KB) - added by AMaini503 3 years ago.

Download all attachments as: .zip

Change History (6)

comment:1 Changed 3 years ago by AMaini503

Owner: changed from nobody to AMaini503
Status: newassigned

comment:2 Changed 3 years ago by AMaini503

Cc: AMaini503 added
Has patch: set
Type: New featureUncategorized

Changed 3 years ago by AMaini503

Attachment: 26241.diff added

comment:3 Changed 3 years ago by AMaini503

--> Modified the message as required for more clarity

Line 267 : collectstatic.py (old)

 self.log("Skipping '%s' (not modified)" % path)

Line 267-269 : collecstatic.py (new)

# Message changed to convey the reason clearly as to why the file was skipped beca
# Compares timestamps using --> http_date
self.log("Skipping '%s' (Dates of last modification are same)" % path)

comment:4 Changed 3 years ago by Claude Paroz

As far as I'm concerned, (not modified) seems rather clear (the file has not been modified since last run). I don't find the proposal better.

comment:5 Changed 3 years ago by Tim Graham

Resolution: worksforme
Status: assignedclosed

I agree with Claude.

Note: See TracTickets for help on using tickets.
Back to Top