Opened 5 years ago

Closed 5 years ago

Last modified 5 years ago

#26214 closed Cleanup/optimization (wontfix)

Better error message for RuntimeError: populate() isn't reentrant

Reported by: Thomas Güttler Owned by: nobody
Component: Core (Other) Version: 1.9
Severity: Normal Keywords:
Cc: Aymeric Augustin Triage Stage: Unreviewed
Has patch: no Needs documentation: no
Needs tests: no Patch needs improvement: no
Easy pickings: no UI/UX: no

Description (last modified by Thomas Güttler)

We were hit by an exception like this in production environment

Traceback (most recent call last):
  File "foobar-fm/foobar_fm/apache/django_wsgi.py", line 4, in <module>
    application = wsgi.get_handler()
  File "djangotools/djangotools/utils/wsgi.py", line 54, in get_handler
    return get_wsgi_application()
  File "lib/python2.7/site-packages/django/core/wsgi.py", line 14, in get_wsgi_application
    django.setup()
  File "lib/python2.7/site-packages/django/__init__.py", line 18, in setup
    apps.populate(settings.INSTALLED_APPS)
  File "lib/python2.7/site-packages/django/apps/registry.py", line 78, in populate
    raise RuntimeError("populate() isn't reentrant")
RuntimeError: populate() isn't reentrant

To debug this, I am missing an very important part:

The Stacktrace of the other one trying to load the config

Here is the code part

            # app_config should be pristine, otherwise the code below won't
            # guarantee that the order matches the order in INSTALLED_APPS.
            if self.app_configs:
                raise RuntimeError("populate() isn't reentrant")

My idea: the first one, who passes above check stores its current stracktrace to a variable.

The if the second fails, and RuntimeError("populate() isn't reentrant") gets executed, the exception can show the stacktrace of the first run.

With this you can debug it. Otherwise you are lost.

What do you think?

Change History (5)

comment:1 Changed 5 years ago by Thomas Güttler

Description: modified (diff)

comment:2 Changed 5 years ago by Tim Graham

Cc: Aymeric Augustin added
Component: Error reportingCore (Other)
Owner: set to nobody
Type: UncategorizedCleanup/optimization

I'm not sure. Aymeric, what's your opinion?

comment:3 Changed 5 years ago by Aymeric Augustin

I understand the reasoning behind this suggestion, but in my experience, trying to be smart with error handling often backfires, and my gut feeling is that this is too magical.

Besides Python 3's exception chaining solves the problem entirely... Let's say that my motivation for doing something is non-existent, given that I don't plan to ever use Python 2 again.

comment:4 Changed 5 years ago by Tim Graham

Resolution: wontfix
Status: newclosed

The rationale makes sense to me.

comment:5 Changed 5 years ago by Thomas Güttler

Python 3's exception chaining solves the problem entirely.

I only used Python2 up to now. I guess it is time to upgrade.

Thank you for your feedback.

Note: See TracTickets for help on using tickets.
Back to Top