Opened 10 years ago

Closed 10 years ago

Last modified 5 months ago

#26151 closed Cleanup/optimization (fixed)

Refactor MigrationWriter.serialize()

Reported by: Yoong Kang Lim Owned by: Yoong Kang Lim
Component: Migrations Version: dev
Severity: Normal Keywords:
Cc: Triage Stage: Accepted
Has patch: yes Needs documentation: no
Needs tests: no Patch needs improvement: no
Easy pickings: no UI/UX: no

Description

The serializer() method in MigrationWriter has a McCabe Cyclomatic Complexity of 50, one of the highest in the entire Django code base.

The serialization logic should be in different Serializer classes. MigrationWriter.serialize() should call a Serializer Factory to obtain the correct Serializer for the value passed in.

Change History (6)

comment:1 by Tim Graham, 10 years ago

Has patch: set
Summary: Refactor MigrationWriter → Refactor MigrationWriter.serialize()
Triage Stage: Unreviewed → Accepted

​PR

comment:2 by Markus Holtermann, 10 years ago

Looks good on the first glimpse :) . I'll need a bit more time to actually look into it.

comment:3 by Yoong Kang Lim, 10 years ago

Owner: changed from nobody to Yoong Kang Lim
Status: new → assigned

comment:4 by Markus Holtermann, 10 years ago

Since a discussion on #django-dev came up earlier I posted to the developer mailing list to get other people's input: ​https://groups.google.com/forum/#!topic/django-developers/yGKl7ZkLac4

comment:5 by Tim Graham <timograham@…>, 10 years ago

Resolution: → fixed
Status: assigned → closed

In 4b1529e2:

Fixed #26151 -- Refactored MigrationWriter.serialize()

Thanks Markus Holtermann for review.

comment:6 by nessita <124304+nessita@…>, 5 months ago

In 0f94ecd4:

Refs #36383, #26151 -- Corrected spelling of DeconstructibleSerializer.

"Deconstructible" is the spelling that Django has settled on, such as
for django.utils.deconstruct. This commit normalizes a
previously-inconsistent class to match the rest of the codebase.

Note: See TracTickets for help on using tickets.
Back to Top