#26119 closed Bug (fixed)
Catch ValueError while parsing urls in URLValidator
Reported by: | Christopher Grebs | Owned by: | nobody |
---|---|---|---|
Component: | Core (Other) | Version: | dev |
Severity: | Normal | Keywords: | |
Cc: | Triage Stage: | Accepted | |
Has patch: | yes | Needs documentation: | no |
Needs tests: | no | Patch needs improvement: | yes |
Easy pickings: | no | UI/UX: | no |
Description (last modified by )
Django uses urllib.urlsplit
to parse an URL but in certain cases this is failing on URLs the regular expressions in URLValidator
deems valid.
This appears to be a problem at least in 1.6+, probably since the URLValidator
exists.
Pull Request: https://github.com/django/django/pull/6010
Change History (8)
comment:1 Changed 7 years ago by
Description: | modified (diff) |
---|---|
Has patch: | set |
Type: | Uncategorized → Bug |
comment:2 Changed 7 years ago by
Description: | modified (diff) |
---|
comment:3 Changed 7 years ago by
Description: | modified (diff) |
---|
comment:4 Changed 7 years ago by
Triage Stage: | Unreviewed → Accepted |
---|---|
Version: | 1.9 → master |
comment:5 Changed 7 years ago by
Patch needs improvement: | set |
---|
As noted on the pull request, looks like a few test cases are missing.
comment:6 Changed 7 years ago by
Component: | Forms → Core (Other) |
---|
Note: See
TracTickets for help on using
tickets.
Can confirm on 1.8 upwards.