forms.DurationField raise a TypeError when passing it a number

[xialvjun]

from django.test import TestCase
from django import forms

class JieDuanModePartForm(forms.Form):
    duration = forms.DurationField()

class JieDuanModeFormTestCase(TestCase):

    def test_data(self):
        data = {'duration': 10800}
        form = JieDuanModePartForm(data=data)
        valid = form.is_valid()
        print(valid)
        print(form.cleaned_data)

code above raise a TypeError...

in forms/fields.py class DurationField method to_python it use:
value = parse_duration(value)
but if wrap it with try block:

        try:
            value = parse_duration(value)
        except TypeError as e:
            raise ValidationError(self.error_messages['invalid'], code='invalid')

things may be better...

Or just value = parse_duration(str(value))

[Keryn Knight]

Chiming in: I suggested xialvjun open this, as I believe it's inconsistent with at least some other fields, even though in the naive case all GET/POST data is stringy, other fields have afforded using real, typed dicts, either from JSON deserialization or just as dictionary validation.

Specifically, the following fields already catch TypeError (gracefully, I think) by a quick glance at the source:

• IntegerField (#24229 is related)
• FloatField
• BaseTemporalField (which DurationField notably is not, though it is notionally related; #18982)
• TypedChoiceField (for obvious reasons)
• TypedMultipleChoiceField (as above)
• ModelChoiceField (#22808)
• ModelMultipleChoiceField (#22808; partially the 1.7.3 DoS vector IIRC; and #21568 looks related?)

[Sasha Gaevsky]

​PR

[Tim Graham <timograham@…>]

In 956cde8:

Fixed #26104 -- Fixed TypeError when passing number to forms.DurationField.

[Tim Graham <timograham@…>]

In 6b258be:

Refs #26104 -- Replaced unnecessary force_str() with force_text().