Opened 9 years ago
Closed 9 years ago
#26089 closed Bug (fixed)
Remove auth's custom user test models (their tables aren't created since Django 1.8)
Reported by: | Simon Charette | Owned by: | Simon Charette |
---|---|---|---|
Component: | contrib.auth | Version: | dev |
Severity: | Normal | Keywords: | |
Cc: | Triage Stage: | Ready for checkin | |
Has patch: | yes | Needs documentation: | no |
Needs tests: | no | Patch needs improvement: | no |
Easy pickings: | no | UI/UX: | no |
Description
Since the introduction of contrib application migrations in 1.8 (#22170) the documented custom user test models table are not created anymore because they are registered to the 'auth'
labeled application but are not part of its shipped migrations.
Based on the fact this was not reported before and that the only uses of ExtensionUser
I can find is either from a vendored version of Django or a copy-pasta of the documentation suggested usage I think we can safely assume it's not commonly used among third-party application who claim to support custom user models. I'll make sure to post the mailing list in order to gather feedback from the community about this point.
Given the models are simply not usable on 1.8 and 1.9 now I'd like to start the deprecation in 1.8 in order order to be able to completely remove them on master but if it's not considered safe enough I came up with a with a workaround that could be backported since there's still no documented way to ship test only models (#7835).
If these models are relied on by the community I would suggest we start deprecating them in 1.10 and adjust the documentation to suggest subclassing the provided abstract models instead.
Change History (11)
comment:1 by , 9 years ago
comment:2 by , 9 years ago
Severity: | Release blocker → Normal |
---|
comment:3 by , 9 years ago
Has patch: | set |
---|
comment:7 by , 9 years ago
Needs documentation: | set |
---|
PR needs a mention in the 1.10 release notes just be on the safe side.
comment:8 by , 9 years ago
Needs documentation: | unset |
---|---|
Status: | new → assigned |
Version: | 1.8 → master |
Here's the PR with release notes.
comment:9 by , 9 years ago
Triage Stage: | Accepted → Ready for checkin |
---|
comment:10 by , 9 years ago
Summary: | The auth custom test model tables are not created anymore. → Remove auth's custom user test models (their tables aren't created since Django 1.8) |
---|
I've written to django-developers with my take on it.