Opened 8 years ago

Last modified 7 years ago

#26052 closed Cleanup/optimization

Consider removing conditional_content_removal — at Version 6

Reported by: Aymeric Augustin Owned by: Susan Tan
Component: HTTP handling Version: 1.9
Severity: Normal Keywords:
Cc: Triage Stage: Ready for checkin
Has patch: yes Needs documentation: no
Needs tests: no Patch needs improvement: no
Easy pickings: no UI/UX: no

Description (last modified by Tim Graham)

It's the last survivor of the "response_fixes" and I think it should go away. Its origin is #5898.

Graham Dumpleton has described better than I would why frameworks should leave the task stripping the body of HEAD requests to servers: http://blog.dscpl.com.au/2009/10/wsgi-issues-with-http-head-requests.html (first five paragraphs).

We should check whether mod_wsgi, gunicorn and uwsgi properly strip the body of HEAD requests before proceeding. We should also move that behavior into runserver -- that is, on the other side of the WSGI.

Change History (6)

comment:1 by Tim Graham, 8 years ago

Triage Stage: UnreviewedAccepted

comment:2 by Akshesh Doshi, 8 years ago

I would like to work on this ticket. Can anyone please guide me exactly what changes would be required in the code.

Thanks

Last edited 8 years ago by Akshesh Doshi (previous) (diff)

comment:3 by Susan Tan, 8 years ago

Owner: changed from nobody to Susan Tan
Status: newassigned

comment:4 by Tim Graham, 8 years ago

Has patch: set

comment:5 by Tim Graham, 8 years ago

Patch needs improvement: set

I think the PR needs improvement as described in the ticket description, "mod_wsgi, gunicorn and uwsgi properly strip the body of HEAD requests before proceeding. We should also move that behavior into runserver."

comment:6 by Tim Graham, 8 years ago

Description: modified (diff)

I observed that gunicorn and runserver (based on Python's server) don't send content for HEAD requests. I didn't check mod_wsgi or uwsgi since they are marginally more complicated to setup a test project. If we go ahead and remove this, one place where developers might see a difference would be in the test client. Do you think it's worth trying to keep it in that context? I lean toward simply removing it and reacting if anyone complains.

Note: See TracTickets for help on using tickets.
Back to Top