Opened 9 years ago

Closed 9 years ago

Last modified 9 years ago

#26051 closed Cleanup/optimization (wontfix)

Rename ATOMIC_REQUESTS to ATOMIC_VIEWS

Reported by: Sven R. Kunze Owned by: nobody
Component: HTTP handling Version: dev
Severity: Normal Keywords:
Cc: tzanke@… Triage Stage: Unreviewed
Has patch: no Needs documentation: no
Needs tests: no Patch needs improvement: no
Easy pickings: no UI/UX: no

Description

Internal discussion within our company revealed that the common misunderstanding results from a slightly wrong name of the config parameter: ATOMIC_REQUESTS

We found that ATOMIC_VIEWS would be better.

Also related: https://code.djangoproject.com/ticket/26043

Change History (3)

comment:1 by Aymeric Augustin, 9 years ago

That makes sense. However I'm not convinced the slight improvement in naming correctness is worth the backwards incompatibility.

There's a proposal for a new middleware schema floating around. Perhaps it will allow implementating a safe TransactionMiddleware again. I'd rather wait for this to happen.

I'm leaving the ticket open to get other opinions.

comment:2 by Tim Graham, 9 years ago

Resolution: wontfix
Status: newclosed

Agreed that if the new middleware proposal works out, that'll be better in the long run. Here's the draft pull request.

comment:3 by TZanke, 9 years ago

Cc: tzanke@… added
Note: See TracTickets for help on using tickets.
Back to Top