Opened 11 years ago

Last modified 5 days ago

#25927 assigned Cleanup/optimization

document django.contrib.gis.utils.ogrinfo

Reported by: Sergey Fedoseev Owned by: Caleb Jeffery Teye
Component: Documentation Version: 1.9
Severity: Normal Keywords:
Cc: Triage Stage: Accepted
Has patch: yes Needs documentation: no
Needs tests: no Patch needs improvement: no
Easy pickings: no UI/UX: no

Description


Change History (10)

comment:1 by Tim Graham, 11 years ago

Triage Stage: Unreviewed → Accepted
Type: Uncategorized → Cleanup/optimization

It seems to be unused and untested. I guess you think it's worth keeping? In that case, could you add some tests too?

comment:2 by Sergey Fedoseev, 11 years ago

No, I think that it should be removed, but related ticket #25923 was not accepted.

comment:3 by ANUSHREE, 8 months ago

I'd like to work on adding documentation for django.contrib.gis.utils.ogrinfo.

comment:4 by Caleb Jeffery Teye, 5 months ago

Owner: changed from nobody to Caleb Jeffery Teye
Status: new → assigned

comment:5 by Caleb Jeffery Teye, 5 months ago

Has patch: set

comment:7 by David Smith, 5 months ago

Patch needs improvement: set

comment:8 by David Smith, 4 months ago

In #37193 we discussed that num_features is used as a list slice without any validation which can cause some odd results. It was discussed that we'd document that behaviour as part of this ticket.

comment:9 by Caleb Jeffery Teye, 4 months ago

Patch needs improvement: unset

comment:10 by Caleb Jeffery Teye, 5 days ago

Hi, I believe all of the review points from the PR are now addressed: the example output is added, the docs are merged into the ogrinspect page, and num_features is documented with the note discussed in #37193. CI is passing. Could someone take a final look and mark this Ready for checkin if it looks good? I'm happy to make any further changes. Thanks!

Note: See TracTickets for help on using tickets.
Back to Top