Opened 3 years ago

Closed 3 years ago

Last modified 3 years ago

#25918 closed Cleanup/optimization (fixed)

Remove unused LOGOUT_URL setting

Reported by: Christoph Schindler Owned by: nobody
Component: Documentation Version: master
Severity: Normal Keywords:
Cc: Triage Stage: Accepted
Has patch: no Needs documentation: no
Needs tests: no Patch needs improvement: no
Easy pickings: yes UI/UX: no

Description

The only code ever using it has been removed with changeset:cba9199.

Some people also seem to confuse it with LOGOUT_REDIRECT_URL (which doesn't exist): http://stackoverflow.com/questions/11933361/django-logout-url-doesnt-redirect-well

The setting should probably be removed entirely?

Attachments (2)

fix_25918.patch (1.4 KB) - added by Christoph Schindler 3 years ago.
fix_25918_2.patch (2.0 KB) - added by Christoph Schindler 3 years ago.

Download all attachments as: .zip

Change History (8)

comment:1 Changed 3 years ago by Tim Graham

Easy pickings: set
Summary: `LOGOUT_URL` is no longer used anywhere in DjangoRemove unused LOGOUT_URL setting
Triage Stage: UnreviewedAccepted
Type: UncategorizedCleanup/optimization
Version: 1.9master

Looks fine to remove, but should be noted in the release notes as a backwards-incompatible change.

comment:2 Changed 3 years ago by Christoph Schindler

The patch itself is trivial, but there is not file for the release notes, yet.

Does this have to be deprecated first?

Changed 3 years ago by Christoph Schindler

Attachment: fix_25918.patch added

comment:3 Changed 3 years ago by Tim Graham

docs/releases/1.10.txt exists in master.

There isn't really a way to deprecate the setting so removing it should be fine. Anyway using it can add it to their local settings.

comment:4 Changed 3 years ago by Christoph Schindler

I'm blind and stupid.

Updated patch is attached.

Changed 3 years ago by Christoph Schindler

Attachment: fix_25918_2.patch added

comment:5 Changed 3 years ago by Tim Graham <timograham@…>

Resolution: fixed
Status: newclosed

In 59f861f:

Fixed #25918 -- Removed unused LOGOUT_URL setting.

Thanks hop for the report and patch.

comment:6 Changed 3 years ago by Tim Graham <timograham@…>

In 030ee158:

Refs #25918 -- Fixed typo in 1.10 release notes.

Note: See TracTickets for help on using tickets.
Back to Top