#25918 closed Cleanup/optimization (fixed)
Remove unused LOGOUT_URL setting
| Reported by: | Christoph Schindler | Owned by: | nobody |
|---|---|---|---|
| Component: | Documentation | Version: | dev |
| Severity: | Normal | Keywords: | |
| Cc: | Triage Stage: | Accepted | |
| Has patch: | no | Needs documentation: | no |
| Needs tests: | no | Patch needs improvement: | no |
| Easy pickings: | yes | UI/UX: | no |
Description
The only code ever using it has been removed with changeset:cba9199.
Some people also seem to confuse it with LOGOUT_REDIRECT_URL (which doesn't exist): http://stackoverflow.com/questions/11933361/django-logout-url-doesnt-redirect-well
The setting should probably be removed entirely?
Attachments (2)
Change History (8)
comment:1 by , 8 years ago
| Easy pickings: | set |
|---|---|
| Summary: | `LOGOUT_URL` is no longer used anywhere in Django → Remove unused LOGOUT_URL setting |
| Triage Stage: | Unreviewed → Accepted |
| Type: | Uncategorized → Cleanup/optimization |
| Version: | 1.9 → master |
comment:2 by , 8 years ago
The patch itself is trivial, but there is not file for the release notes, yet.
Does this have to be deprecated first?
by , 8 years ago
| Attachment: | fix_25918.patch added |
|---|
comment:3 by , 8 years ago
docs/releases/1.10.txt exists in master.
There isn't really a way to deprecate the setting so removing it should be fine. Anyway using it can add it to their local settings.
by , 8 years ago
| Attachment: | fix_25918_2.patch added |
|---|
Note:
See TracTickets
for help on using tickets.
Looks fine to remove, but should be noted in the release notes as a backwards-incompatible change.