#25895 closed Cleanup/optimization (fixed)
Customizing user admin docs shouldn't override name.
| Reported by: | Justin Abrahms | Owned by: | nobody |
|---|---|---|---|
| Component: | Documentation | Version: | dev |
| Severity: | Normal | Keywords: | |
| Cc: | Triage Stage: | Ready for checkin | |
| Has patch: | yes | Needs documentation: | no |
| Needs tests: | no | Patch needs improvement: | no |
| Easy pickings: | yes | UI/UX: | no |
Description
https://github.com/django/django/blob/master/docs/topics/auth/customizing.txt#L342
In the above documentation, we're inheriting from UserAdmin while renaming our own class UserAdmin. Instead, we should rename one of the two of those so it is more clear (and generally doesn't throw pylint errors).
Attachments (1)
Change History (8)
comment:1 by , 8 years ago
| Triage Stage: | Unreviewed → Accepted |
|---|---|
| Type: | Uncategorized → Cleanup/optimization |
| Version: | 1.9 → master |
by , 8 years ago
| Attachment: | 25895.diff added |
|---|
comment:2 by , 8 years ago
| Has patch: | set |
|---|
comment:4 by , 8 years ago
| Triage Stage: | Accepted → Ready for checkin |
|---|
In release notes, you can let one of MyUserAdmin / BaseUserAdmin as UserAdmin.
Note:
See TracTickets
for help on using tickets.
I think
import UserAdmin as BaseUserAdminis an okay way to go. Any preferences?