Opened 9 years ago

Closed 8 years ago

Last modified 8 years ago

#2587 closed defect (fixed)

[patch] unnecessary escaping of fields in admin_doc templates

Reported by: Gary Wilson <gary.wilson@…> Owned by: adrian
Component: contrib.admin Version: master
Severity: normal Keywords:
Cc: gary.wilson@…, treborhudson@… Triage Stage: Unreviewed
Has patch: yes Needs documentation: no
Needs tests: no Patch needs improvement: no
Easy pickings: UI/UX:

Description

The doc.model_detail view is writing html to verbose to provide links to related models, but this is then getting escaped in the template.

Attachments (1)

admin_doc-view_detail.diff (439 bytes) - added by treborhudson@… 8 years ago.
Removes unnecessary escaping from admin_doc/view_detail.html template

Download all attachments as: .zip

Change History (6)

comment:1 Changed 9 years ago by adrian

  • Resolution set to fixed
  • Status changed from new to closed

(In [3642]) Fixed #2587 -- Removed unnecessary escaping from admin_doc/model_detail.html template. Thanks for reporting, Gary Wilson

comment:2 Changed 8 years ago by treborhudson@…

  • Resolution fixed deleted
  • Status changed from closed to reopened
  • Summary changed from unnecessary escaping of field.verbose in admin_doc/model_detail.html to unnecessary escaping of fields in admin_doc templates

The same bug applies to: view_detail.html -> summary|escape

This may be another bug, but many of the admin views in the "Home > Documentation > Views" list have a "_checklogin" appended which results in a 404 error. Each is listed as: "View function: django.contrib.admin.views.decorators._checklogin" and the URL goes to: "http://localhost:8000/admin/doc/views/django.contrib.admin.views.decorators._checklogin/"

comment:3 Changed 8 years ago by Gary Wilson <gary.wilson@…>

  • Cc gary.wilson@… added

Changed 8 years ago by treborhudson@…

Removes unnecessary escaping from admin_doc/view_detail.html template

comment:4 Changed 8 years ago by treborhudson@…

  • Cc treborhudson@… added
  • Summary changed from unnecessary escaping of fields in admin_doc templates to [patch] unnecessary escaping of fields in admin_doc templates

Adding patch to summary...

comment:5 Changed 8 years ago by mtredinnick

  • Resolution set to fixed
  • Status changed from reopened to closed

(In [3856]) Fixed #2587 -- Removed some escaping from the summary fields.

Note: See TracTickets for help on using tickets.
Back to Top