Opened 9 years ago
Closed 9 years ago
#25865 closed Cleanup/optimization (fixed)
OSMGeoAdmin should require GDAL only if model has fields with SRID that differs from map srid
Reported by: | Sergey Fedoseev | Owned by: | Sergey Fedoseev |
---|---|---|---|
Component: | GIS | Version: | 1.9 |
Severity: | Normal | Keywords: | |
Cc: | Triage Stage: | Accepted | |
Has patch: | yes | Needs documentation: | no |
Needs tests: | no | Patch needs improvement: | yes |
Easy pickings: | no | UI/UX: | no |
Description (last modified by )
ATM OSMGeoAdmin
raises exception while initialization if GDAL isn't available, that seems to be too strong check because GDAL is not needed if SRID of model field is the same as needed by map widget.
Change History (8)
comment:1 by , 9 years ago
Owner: | changed from | to
---|---|
Status: | new → assigned |
comment:2 by , 9 years ago
Has patch: | set |
---|
comment:3 by , 9 years ago
Description: | modified (diff) |
---|
comment:4 by , 9 years ago
I'm a bit hesitant here. Do you see many projects who store there data with the projected spherical mercator (3857)? I'm not even sure we should encourage that.
comment:5 by , 9 years ago
Honestly speaking I have deal with the only GIS project =)
My position on this: if we are supporting GIS stuff running even without GDAL we should try to minimize dependency from it as hard as we can while this doesn't lead us to reinventing it.
I could even see imaginable use case for storing the data in 3857: to store it along with the data in 4326 to get rid of the overhead on transforming coordinates every time they are should be represented to the users.
comment:6 by , 9 years ago
Type: | Uncategorized → Cleanup/optimization |
---|
It looks to me like the current error would be raised at compile time. Will the new error be raised at compile time or only when accessing the admin page? I think the former is much better. If the ticket is accepted, it might be better to convert it to a system check if possible.
comment:7 by , 9 years ago
Patch needs improvement: | set |
---|---|
Triage Stage: | Unreviewed → Accepted |
I'll tentatively accept the ticket given it has sat on the unreviewed queue for several weeks and mark it "patch needs improvement" until GIS contributors decide on whether or not to move forward with it.
PR -- https://github.com/django/django/pull/5770