Opened 9 years ago
Closed 9 years ago
#25835 closed Cleanup/optimization (fixed)
remove backwards-compatibility alias `Adaptor`
Reported by: | Sergey Fedoseev | Owned by: | Sergey Fedoseev |
---|---|---|---|
Component: | GIS | Version: | dev |
Severity: | Normal | Keywords: | |
Cc: | Triage Stage: | Accepted | |
Has patch: | yes | Needs documentation: | no |
Needs tests: | no | Patch needs improvement: | no |
Easy pickings: | no | UI/UX: | no |
Description
All spatial operations classes have Adaptor
class attribute and comments say that it backwards-compatibility alias for Adapter
. This attribute was added to fix #13315.
It seems however that it doesn't provide any backwards-compatibility. Quoting comment from mentioned ticket:
It's a matter of debate to whether this is a backwards-incompatible change -- the root cause of the issue is that
SpatialBackend
(andSpatialBackend.Adaptor
) no longer exists due to multiple-database support, however, it was never documented to begin with.
I did indeed rename the
Adaptor
objects to the more common spelling ofAdapter
; providing aliases is a possibility -- however, I also changed the root namespace todjango.contrib.gis.db.backends
(thes
was added), thus even the aliases wouldn't even be truly backwards-compatible.
As could be seen from comments of that ticket it was proposed to add this alias to deprecation timeline, but for some reason this wasn't done.
Change History (4)
comment:1 by , 9 years ago
Owner: | changed from | to
---|---|
Status: | new → assigned |
comment:2 by , 9 years ago
Triage Stage: | Unreviewed → Accepted |
---|
comment:3 by , 9 years ago
Has patch: | set |
---|
PR -- https://github.com/django/django/pull/5746