Opened 9 years ago

Closed 9 years ago

#25823 closed Cleanup/optimization (fixed)

String inconststency between "View documentation" and "Back to Views Documentation"

Reported by: gunchleoc Owned by: nobody
Component: contrib.admindocs Version: dev
Severity: Normal Keywords: i18n
Cc: Triage Stage: Accepted
Has patch: yes Needs documentation: no
Needs tests: no Patch needs improvement: yes
Easy pickings: yes UI/UX: no

Description

This should be either

"Views Documentation" and "Back to Views Documentation", or

"View Documentation" and "Back to View Documentation".

Location:

contrib/admindocs/templates/admin_doc/view_index.html:16

contrib/admindocs/templates/admin_doc/view_detail.html:32

Change History (9)

comment:1 by Baptiste Mispelon, 9 years ago

Easy pickings: set
Triage Stage: UnreviewedAccepted
Type: UncategorizedCleanup/optimization

Hi,

You're right. I think we should use the plural form in both places.
Are you interested in contributing a pull request for this?

Thanks.

comment:2 by gunchleoc, 9 years ago

Yes, I can do that - low hanging fruit :)

comment:4 by Baptiste Mispelon, 9 years ago

Has patch: set
Triage Stage: AcceptedReady for checkin

Looks good to me. Thanks!

comment:5 by Tim Graham, 9 years ago

Patch needs improvement: set
Triage Stage: Ready for checkinAccepted
Version: 1.9rc1master

Actually it looks to me like singular is more consistent with similar headers: "Template tag documentation", "Template filter documentation", "Model documentation".

comment:6 by gunchleoc, 9 years ago

I'd be happy with that - do we have agreement on this? If so, I will change it.

comment:7 by Baptiste Mispelon, 9 years ago

I think timgraham is right. I hadn't checked what the other headers used, my mistake.

comment:8 by gunchleoc, 9 years ago

OK, done.

comment:9 by Tim Graham <timograham@…>, 9 years ago

Resolution: fixed
Status: newclosed

In 89b6856a:

Fixed #25823 -- Made some titles consistent in admindocs.

Note: See TracTickets for help on using tickets.
Back to Top