Opened 8 years ago
Closed 8 years ago
#25823 closed Cleanup/optimization (fixed)
String inconststency between "View documentation" and "Back to Views Documentation"
| Reported by: | gunchleoc | Owned by: | nobody |
|---|---|---|---|
| Component: | contrib.admindocs | Version: | dev |
| Severity: | Normal | Keywords: | i18n |
| Cc: | Triage Stage: | Accepted | |
| Has patch: | yes | Needs documentation: | no |
| Needs tests: | no | Patch needs improvement: | yes |
| Easy pickings: | yes | UI/UX: | no |
Description
This should be either
"Views Documentation" and "Back to Views Documentation", or
"View Documentation" and "Back to View Documentation".
Location:
contrib/admindocs/templates/admin_doc/view_index.html:16
contrib/admindocs/templates/admin_doc/view_detail.html:32
Change History (9)
comment:1 by , 8 years ago
| Easy pickings: | set |
|---|---|
| Triage Stage: | Unreviewed → Accepted |
| Type: | Uncategorized → Cleanup/optimization |
comment:4 by , 8 years ago
| Has patch: | set |
|---|---|
| Triage Stage: | Accepted → Ready for checkin |
Looks good to me. Thanks!
comment:5 by , 8 years ago
| Patch needs improvement: | set |
|---|---|
| Triage Stage: | Ready for checkin → Accepted |
| Version: | 1.9rc1 → master |
Actually it looks to me like singular is more consistent with similar headers: "Template tag documentation", "Template filter documentation", "Model documentation".
comment:6 by , 8 years ago
I'd be happy with that - do we have agreement on this? If so, I will change it.
comment:7 by , 8 years ago
I think timgraham is right. I hadn't checked what the other headers used, my mistake.
Note:
See TracTickets
for help on using tickets.
Hi,
You're right. I think we should use the plural form in both places.
Are you interested in contributing a pull request for this?
Thanks.