Opened 8 years ago

Closed 8 years ago

#25806 closed Cleanup/optimization (fixed)

syndication.Feed uses name-mangling for __get_dynamic_attr

Reported by: Keryn Knight Owned by: nobody
Component: contrib.syndication Version: dev
Severity: Normal Keywords:
Cc: django@… Triage Stage: Accepted
Has patch: yes Needs documentation: no
Needs tests: no Patch needs improvement: no
Easy pickings: no UI/UX: no

Description

​This method being name-mangled confused me a while back but I forgot about it, because it's really rare to actually use that aspect of Python's method naming, in my experience.

I can't see the point of it, really.

Change History (4)

comment:1 by Tim Graham, 8 years ago

What change should be made?

comment:2 by Keryn Knight, 8 years ago

Hi Tim,
Sorry, rather forgot the salient purpose of the ticket, didn't I? I'm proposing changing it to be a normal private method (_get_dynamic_attr) so that subclasses can easily modify what it does.

comment:3 by Tim Graham, 8 years ago

Has patch: set
Triage Stage: Unreviewed → Accepted

Seems okay to me. ​PR

comment:4 by Tim Graham <timograham@…>, 8 years ago

Resolution: → fixed
Status: new → closed

In 2c0be90:

Fixed #25806 -- Removed name mangling from syndication.Feed's _get_dynamic_attr().

It doesn't seem to serve any purpose.

Note: See TracTickets for help on using tickets.
Back to Top