Opened 8 years ago

Closed 8 years ago

#25784 closed Cleanup/optimization (fixed)

help on collect_static fails if no STATIC_ROOT is defined

Reported by: Rapolas K. Owned by: Alex Morozov
Component: contrib.staticfiles Version: dev
Severity: Normal Keywords:
Cc: Triage Stage: Ready for checkin
Has patch: yes Needs documentation: no
Needs tests: no Patch needs improvement: no
Easy pickings: yes UI/UX: no


I wanted to read what collect_static command does and typed: ./ help collect_static. Instead of seeing the help text, I got ImproperlyConfigured exception about attempt to use collect_static with missing STATIC_ROOT setting. I don't think trying to read help text should raise an exception. I've tried with 1.8.6 and 1.9rc1 versions.

Change History (9)

comment:1 by Tim Graham, 8 years ago

Component: Uncategorizedcontrib.staticfiles
Triage Stage: UnreviewedAccepted
Type: UncategorizedCleanup/optimization
Version: 1.9rc1master

Would be nice if not too difficult.

comment:2 by Claude Paroz, 8 years ago

Easy pickings: set

Yes, it's easy if we make self.local a (cached?) property.

comment:3 by Alex Morozov, 8 years ago

Owner: changed from nobody to Alex Morozov
Status: newassigned

Will give it a try.

comment:5 by Claude Paroz, 8 years ago

Patch needs improvement: set

Left some remarks on the pull request.

comment:6 by Alex Morozov, 8 years ago

Updated the pr.

comment:7 by Tim Graham, 8 years ago

Patch needs improvement: unset
Triage Stage: AcceptedReady for checkin

For future reference, don't forget to uncheck "Patch needs improvement" after you update it so that the ticket returns to the review queue.

comment:8 by Alex Morozov, 8 years ago

Sure, will do. Thank you.

comment:9 by Claude Paroz <claude@…>, 8 years ago

Resolution: fixed
Status: assignedclosed

In 6ca163d:

Fixed #25784 -- Prevented an exception on collectstatic help

Made the help collectstatic don't fail if the STATIC_ROOT
setting is empty.

Note: See TracTickets for help on using tickets.
Back to Top