Opened 9 years ago

Closed 9 years ago

Last modified 4 years ago

#25735 closed New feature (fixed)

Add test tagging to Django test runner

Reported by: Carl Meyer Owned by: Jakub Paczkowski
Component: Testing framework Version: 1.8
Severity: Normal Keywords:
Cc: jakub@… Triage Stage: Accepted
Has patch: yes Needs documentation: no
Needs tests: no Patch needs improvement: no
Easy pickings: no UI/UX: no

Description

This idea has come up multiple times in the last few years, most recently in the discussion of #25653.

A pull request for it already exists: https://github.com/django/django/pull/5585

Change History (10)

comment:1 by Carl Meyer, 9 years ago

Triage Stage: Ready for checkinAccepted

There is perhaps one other design decision we should at least consider before this is merged. The current implementation filters out tests that are de-selected by tags from the test suite, so it will be as if those tests weren't discovered at all. Is that what we want, or would it be better if de-selected tags were skipped using the unittest test-skipping functionality?

I haven't investigated feasibility of the latter, but I think it should be possible if we prefer it.

comment:2 by Carl Meyer, 9 years ago

Triage Stage: AcceptedReady for checkin

I think we should go ahead with this as-is, and if it turns out in practice skipping would be better, that can be done as a follow-up improvement.

comment:3 by Jakub Paczkowski, 9 years ago

Cc: jakub@… added
Owner: changed from nobody to Jakub Paczkowski
Status: newassigned

comment:4 by Tim Graham, 9 years ago

Patch needs improvement: set
Triage Stage: Ready for checkinAccepted

Left comments for improvement.

comment:5 by Tim Graham, 9 years ago

Patch needs improvement: unset

comment:6 by Tim Graham <timograham@…>, 9 years ago

Resolution: fixed
Status: assignedclosed

In d4dc775:

Fixed #25735 -- Added support for test tags to DiscoverRunner.

Thanks Carl Meyer, Claude Paroz, and Simon Charette for review.

comment:7 by Tim Graham <timograham@…>, 9 years ago

In 032f5a78:

Refs #25735 -- Made @tag decorator importable from django.test.

comment:8 by Mariusz Felisiak <felisiak.mariusz@…>, 4 years ago

In 3704481:

Refs #25735 -- Added tags/exclude_tags arguments to DiscoverRunner docs.

comment:9 by Mariusz Felisiak <felisiak.mariusz@…>, 4 years ago

In 8298775d:

[3.2.x] Refs #25735 -- Added tags/exclude_tags arguments to DiscoverRunner docs.

Backport of 37044817f9a57126d655f216019e8c8cca7c151b from main

comment:10 by Mariusz Felisiak <felisiak.mariusz@…>, 4 years ago

In 11d241dc:

[3.1.x] Refs #25735 -- Added tags/exclude_tags arguments to DiscoverRunner docs.

Backport of 37044817f9a57126d655f216019e8c8cca7c151b from main.

Note: See TracTickets for help on using tickets.
Back to Top