Opened 9 years ago
Closed 9 years ago
#25689 closed Cleanup/optimization (wontfix)
Merge staticfiles into core
Reported by: | Collin Anderson | Owned by: | nobody |
---|---|---|---|
Component: | contrib.staticfiles | Version: | dev |
Severity: | Normal | Keywords: | |
Cc: | cmawebsite@… | Triage Stage: | Someday/Maybe |
Has patch: | no | Needs documentation: | no |
Needs tests: | no | Patch needs improvement: | no |
Easy pickings: | no | UI/UX: | no |
Description
(James Aylett on stage at duth)
If you accidentally use {% load static %} instead of {% load staticfiles %} you won't take advantage of storage engines. However, 3rd-party apps won't know if the staticfiles library is installed or not.
One solution he mentioned is having {% load static %} match the behavior of {% load admin_static %} (where it uses staticfiles only if it's installed), but that would probably involve core importing code from contrib (usually a no-no).
Another option he gave was merging staticfiles into core. He thought it might be contentious, but I think is actually a better idea.
Change History (7)
comment:1 by , 9 years ago
comment:2 by , 9 years ago
Triage Stage: | Unreviewed → Someday/Maybe |
---|
How about a discussion on the mailing list first? :-)
comment:4 by , 9 years ago
actually, I do prefer the approach in #21221, as long as we're ok with a contrib import from core.
comment:5 by , 9 years ago
I'm sad to import contrib in core but perhaps that's the pragmatic thing. Count me as a -1.
comment:7 by , 9 years ago
Cc: | added |
---|---|
Resolution: | → wontfix |
Status: | new → closed |
I'll wontfix this assuming #21221 moves through smoothly.
We could leave
HashedFilesMixin
,ManifestFilesMixin
, etc in contrib, but at least make sure the template tag works correctly. People can referenceManifestFilesMixin
in their settings files if they want to use it.