Opened 7 years ago

Closed 7 years ago

#25689 closed Cleanup/optimization (wontfix)

Merge staticfiles into core

Reported by: Collin Anderson Owned by: nobody
Component: contrib.staticfiles Version: dev
Severity: Normal Keywords:
Cc: cmawebsite@… Triage Stage: Someday/Maybe
Has patch: no Needs documentation: no
Needs tests: no Patch needs improvement: no
Easy pickings: no UI/UX: no

Description

(James Aylett on stage at duth)

If you accidentally use {% load static %} instead of {% load staticfiles %} you won't take advantage of storage engines. However, 3rd-party apps won't know if the staticfiles library is installed or not.

One solution he mentioned is having {% load static %} match the behavior of {% load admin_static %} (where it uses staticfiles only if it's installed), but that would probably involve core importing code from contrib (usually a no-no).

Another option he gave was merging staticfiles into core. He thought it might be contentious, but I think is actually a better idea.

Change History (7)

comment:1 Changed 7 years ago by Collin Anderson

We could leave HashedFilesMixin, ManifestFilesMixin, etc in contrib, but at least make sure the template tag works correctly. People can reference ManifestFilesMixin in their settings files if they want to use it.

comment:2 Changed 7 years ago by Tim Graham

Triage Stage: UnreviewedSomeday/Maybe

How about a discussion on the mailing list first? :-)

comment:3 Changed 7 years ago by Claude Paroz

See also #21221

comment:4 Changed 7 years ago by Collin Anderson

actually, I do prefer the approach in #21221, as long as we're ok with a contrib import from core.

comment:5 Changed 7 years ago by Aymeric Augustin

I'm sad to import contrib in core but perhaps that's the pragmatic thing. Count me as a -1.

comment:6 Changed 7 years ago by Aymeric Augustin

Err I meant a -0. Great typo there.

comment:7 Changed 7 years ago by Collin Anderson

Cc: cmawebsite@… added
Resolution: wontfix
Status: newclosed

I'll wontfix this assuming #21221 moves through smoothly.

Note: See TracTickets for help on using tickets.
Back to Top