Opened 3 years ago

Closed 7 weeks ago

#25678 closed Bug (fixed)

migrate scalar to array field in PostrgreSQL fails

Reported by: Mark Mikofski Owned by: nobody
Component: Migrations Version: master
Severity: Normal Keywords: PostgreSQL, ArrayField
Cc: Triage Stage: Accepted
Has patch: no Needs documentation: no
Needs tests: no Patch needs improvement: no
Easy pickings: no UI/UX: no


Python 2.7.10

Problem: Scalar type might not be cast to array of same type explicitly with USING SQL command?

Solution: Use psql to migrate fields manually

dev=# ALTER TABLE my_app_mymodel ALTER COLUMN "my_field" TYPE double precision [] USING array["my_field"]::double precision[];


given an initial model:

class MyModel(models.Model):
    my_field = models.FloatField()

change this to ArrayField

class MyModel(models.Model):
    my_field = ArrayField(

then make migrations and migrate

$ ./ makemigrations
$ ./ migrate

returns the following traceback:

Operations to perform:
  Synchronize unmigrated apps: staticfiles, messages
  Apply all migrations: admin, contenttypes, my_app, auth, sessions
Synchronizing apps without migrations:
  Creating tables...
    Running deferred SQL...
  Installing custom SQL...
Running migrations:
  Rendering model states... DONE
  Applying my_app.0XYZ_auto_YYYYMMDD_hhmm...Traceback (most recent call last):
  File "./", line 10, in <module>
  File "C:\Python27\lib\site-packages\django\core\management\", line 351, in execute_from_command_line
  File "C:\Python27\lib\site-packages\django\core\management\", line 343, in execute
  File "C:\Python27\lib\site-packages\django\core\management\", line 394, in run_from_argv
    self.execute(*args, **cmd_options)
  File "C:\Python27\lib\site-packages\django\core\management\", line 445, in execute
    output = self.handle(*args, **options)
  File "C:\Python27\lib\site-packages\django\core\management\commands\", line 222, in handle
    executor.migrate(targets, plan, fake=fake, fake_initial=fake_initial)
  File "C:\Python27\lib\site-packages\django\db\migrations\", line 110, in migrate
    self.apply_migration(states[migration], migration, fake=fake, fake_initial=fake_initial)
  File "C:\Python27\lib\site-packages\django\db\migrations\", line 148, in apply_migration
    state = migration.apply(state, schema_editor)
  File "C:\Python27\lib\site-packages\django\db\migrations\", line 115, in apply
    operation.database_forwards(self.app_label, schema_editor, old_state, project_state)
  File "C:\Python27\lib\site-packages\django\db\migrations\operations\", line 201, in database_forwards
    schema_editor.alter_field(from_model, from_field, to_field)
  File "C:\Python27\lib\site-packages\django\db\backends\base\", line 484, in alter_field
    old_db_params, new_db_params, strict)
  File "C:\Python27\lib\site-packages\django\db\backends\base\", line 636, in _alter_field
  File "C:\Python27\lib\site-packages\django\db\backends\base\", line 111, in execute
    cursor.execute(sql, params)
  File "C:\Python27\lib\site-packages\django\db\backends\", line 79, in execute
    return super(CursorDebugWrapper, self).execute(sql, params)
  File "C:\Python27\lib\site-packages\django\db\backends\", line 64, in execute
    return self.cursor.execute(sql, params)
  File "C:\Python27\lib\site-packages\django\db\", line 97, in __exit__
    six.reraise(dj_exc_type, dj_exc_value, traceback)
  File "C:\Python27\lib\site-packages\django\db\backends\", line 64, in execute
    return self.cursor.execute(sql, params)
django.db.utils.ProgrammingError: column "my_field " cannot be cast automatically to type double precision[]
HINT:  Specify a USING expression to perform the conversion.

Change History (8)

comment:1 Changed 3 years ago by Mark Mikofski

using sqlmigrate it can be seen that the SQL used does not include the USING command to cast the old column to the new type

$ ./ sqlmigrate my_app 0XYZ_auto_YYYYMMDD_hhmm
ALTER TABLE "my_app_mymodel" ALTER COLUMN "my_field" TYPE double precision[];


it should be ...

ALTER TABLE "my_app_mymodel" ALTER COLUMN "my_field" TYPE double precision[] USING array["my_field"]::double precision[];


comment:2 Changed 3 years ago by Simon Charette

Version: 1.8master

The USING part was added by #25002 which should be part of Django 1.9 but scalar to array conversion might require adjustment.

Can you confirm the issue also exists in 1.9?

comment:3 Changed 3 years ago by Mark Mikofski

I'm working on a patch for this:

  • add new SQL statement here: django/db/backends/base/
    sql_alter_column_array = "ALTER COLUMN %(column)s TYPE %(type)s USING array[%(column)s]::%(type)s"
  • in _alter_field() at L555 check if casting to an array and call something similar to _alter_column_type_sql() at L753 with new SQL statements then return fragments.

comment:4 Changed 3 years ago by Tim Graham

Triage Stage: UnreviewedAccepted
Type: UncategorizedBug

comment:5 Changed 3 years ago by Simon Charette

@mikofski I suggest we name the attribute sql_alter_scalar_column_to_array instead and add a test to make sure array to array conversion doesn't use it (e.g. text[] -> int[])

comment:6 Changed 3 years ago by Mark Mikofski

@charettes okay, just catching up - I haven't checked django-1.9 yet, I should do that first to see if any changes are needed. Thanks!

comment:7 Changed 3 years ago by Simon Charette

Keywords: migrate removed

comment:8 Changed 7 weeks ago by Mark Mikofski

Resolution: fixed
Status: newclosed

this was fixed in #25002 in by commit 73040e58 thanks!

Note: See TracTickets for help on using tickets.
Back to Top