Opened 8 years ago

Closed 8 years ago

#25667 closed Bug (fixed)

Misspelling in docutils setting override

Reported by: Ville Skyttä Owned by: nobody
Component: contrib.admindocs Version: dev
Severity: Normal Keywords:
Cc: Triage Stage: Accepted
Has patch: yes Needs documentation: no
Needs tests: no Patch needs improvement: no
Easy pickings: no UI/UX: no


Should be initial_header_level, not inital_header_level.

Change History (7)

comment:1 by Tim Graham, 8 years ago

As this has been broken forever ("Imported Django from private SVN repository") contains the misspelling, I wonder if we need to fix it (or what change fixing it causes)?

comment:2 by Ville Skyttä, 8 years ago

Has patch: set

Frankly, I don't know the answer to either, I just happened to stumble upon this while checking for general misspellings.

comment:3 by Tim Graham, 8 years ago

Needs tests: set
Triage Stage: UnreviewedAccepted

I think it makes sense, but we should try to add a test.

comment:4 by Ville Skyttä, 8 years ago

Needs tests: unset

I took a look, and in my opinion initial header level 3 is desirable; h3 looks better than h1 there, and the page already contains a h1 (and seemingly also a h2) and there at least used to be a general recommendation not to have more than one h1 in web pages. PR force-updated with a test case.

comment:5 by Tim Graham, 8 years ago

Patch needs improvement: set

Test could use some improvement as noted on the PR.

comment:6 by Ville Skyttä, 8 years ago

Patch needs improvement: unset

PR force-updated

comment:7 by Tim Graham <timograham@…>, 8 years ago

Resolution: fixed
Status: newclosed

In 4d0f883:

Fixed #25667 -- Fixed admindocs initial_header_level.

Note: See TracTickets for help on using tickets.
Back to Top