Opened 9 years ago

Closed 9 years ago

Last modified 9 years ago

#25566 closed Bug (fixed)

Admin popup_response.html needs a title

Reported by: Ville Skyttä Owned by: nobody
Component: contrib.admin Version: dev
Severity: Normal Keywords:
Cc: Triage Stage: Ready for checkin
Has patch: yes Needs documentation: no
Needs tests: no Patch needs improvement: no
Easy pickings: yes UI/UX: no

Description

django/contrib/admin/templates/admin/popup_response.html has:

<title></title>

http://html5.validator.nu/ flags an empty title as an error: "Error: Element title must not be empty."

http://www.w3.org/TR/html5/document-metadata.html#the-title-element says that title must be "Text that is not inter-element whitespace." Adding the title would be trivial, but what to put there?

Something generic like {% trans 'Popup closing...' %}?

Change History (5)

comment:1 by Tim Graham, 9 years ago

Easy pickings: set
Triage Stage: UnreviewedAccepted

Your suggestion seems okay to me.

comment:2 by Ville Skyttä, 9 years ago

Has patch: set

comment:3 by Tim Graham, 9 years ago

Triage Stage: AcceptedReady for checkin

comment:4 by Ville Skyttä <ville.skytta@…>, 9 years ago

Resolution: fixed
Status: newclosed

In aff4b75c:

Fixed #25566 -- Added title to admin's closing popup response page

comment:5 by Tim Graham <timograham@…>, 9 years ago

In 094a608:

[1.9.x] Fixed #25566 -- Added title to admin's closing popup response page

Backport of aff4b75c34d62ec932414b5099016007fff17317 from master

Note: See TracTickets for help on using tickets.
Back to Top