Opened 10 years ago

Closed 10 years ago

Last modified 10 years ago

#25560 closed Bug (fixed)

Empty string related name should be invalid

Reported by: Simon Charette Owned by: nobody
Component: Core (System checks) Version: dev
Severity: Normal Keywords:
Cc: Triage Stage: Ready for checkin
Has patch: yes Needs documentation: no
Needs tests: no Patch needs improvement: no
Easy pickings: no UI/UX: no

Description

The actual model field check is ​skipped if the related_name is an empty string when a warning should be raised since it's an invalid Python identifier.

Change History (4)

comment:1 by Simon Charette, 10 years ago

Has patch: set

​PR

comment:2 by Tim Graham, 10 years ago

Component: Uncategorized → Core (System checks)
Triage Stage: Accepted → Ready for checkin

comment:3 by Simon Charette <charette.s@…>, 10 years ago

Resolution: → fixed
Status: new → closed

In c1b6a8a:

Fixed #25560 -- Made empty string related_name invalid.

Thanks to Ali Lotfi for the initial report and patch
and Tim Graham for the review.

comment:4 by Tim Graham <timograham@…>, 10 years ago

In 3aeb84df:

[1.9.x] Fixed #25560 -- Made empty string related_name invalid.

Thanks to Ali Lotfi for the initial report and patch
and Tim Graham for the review.

Backport of c1b6a8a98b08fedfa3f3c69bc7add94c5841ba57 from master

Note: See TracTickets for help on using tickets.
Back to Top