#2552 closed enhancement (fixed)
[contrib] get IP from X-Forwarded-For
Reported by: | Owned by: | Adrian Holovaty | |
---|---|---|---|
Component: | Metasystem | Version: | |
Severity: | normal | Keywords: | |
Cc: | Triage Stage: | Unreviewed | |
Has patch: | no | Needs documentation: | no |
Needs tests: | no | Patch needs improvement: | no |
Easy pickings: | no | UI/UX: | no |
Description
SmileyChris suggest this would be contrib worthy.
from myblog
on some shared hosting environments like webfaction they install a reverse proxy solution where you run a apache2 webserver on a custom port, and the main webserver forwards the request through to you.
This works great, and I’ve been using things like this for years, but the problem you get is that all the requests appear to be from 127.0.0.1 (or the machine which is doing the proxying for you) which isn’t the best if you want to record that stuff.
webfaction fixes this in the log files for you automatically, but that doesn’t help you if you want to do something with the IP# in django.
enter FixIP it takes the X-Forwarded-For header sent by compliant servers which holds the real IP and makes django work properly.
installation is easy.. just add the routine to your middleware settings ala
MIDDLEWARE_CLASSES = ( "django.middleware.common.CommonMiddleware", "zilbo.common.utils.middleware.fixip.FixIP", ...
code is available here
Change History (4)
comment:1 by , 18 years ago
Resolution: | → fixed |
---|---|
Status: | new → closed |
comment:2 by , 18 years ago
For the record, I put this in django/middleware/http.py
instead of in django/contrib
because we don't have the precedent of middleware in django/contrib
.
comment:3 by , 13 years ago
Easy pickings: | unset |
---|---|
UI/UX: | unset |
just for the one who drop here from a google request, the fix saying it's in middleware/http.py means that you have to use the following syntax to use this middleware (which fix the IP properly using HTTP header X-Forwarded-For if present) :
MIDDLEWARE_CLASSES = ( ... 'django.middleware.http.FixIP', )
comment:4 by , 13 years ago
forget it : this middleware is not in django anymore,
see there : https://docs.djangoproject.com/en/dev/releases/1.1/#removed-setremoteaddrfromforwardedfor-middleware
(In [3602]) Fixed #2552 -- Added SetRemoteAddrFromForwardedFor middleware and documentation. Thanks, Ian Holsman