Opened 7 years ago

Closed 7 years ago

#25519 closed Bug (fixed)

"View Site" in admin shows wrong URL if site is not hosted at root

Reported by: Dheerendra Rathor Owned by: nobody
Component: contrib.admin Version: 1.8
Severity: Normal Keywords:
Cc: Triage Stage: Accepted
Has patch: yes Needs documentation: yes
Needs tests: no Patch needs improvement: no
Easy pickings: no UI/UX: no

Description

In django-admin VIEW_SITE should redirect to base of hosted site. If site is not hosted at the root but at some other location, then still VIEW_SITE redirects to absolute root of the site.

Example:
Suppose site is hosted at http://example.com/mysite/ and I'm using SCRIPT_NAME HTTP header in my proxy server. {% url 'some_url' %} results into /mysite/some/url/ which is correct. But site_url in django admin is hardcoded to /.

Here is the relevant code snippet from django.contrib.admin.sites.AdminSite

# URL for the "View site" link at the top of each admin page.
site_url = '/'

Change History (7)

comment:1 Changed 7 years ago by Dheerendra Rathor

Type: UncategorizedBug

comment:2 Changed 7 years ago by Tim Graham

Easy pickings: unset
Summary: VIEW_SITE in django-admin shows wrong URL if site is not hosted at root!"View Site" in admin shows wrong URL if site is not hosted at root
Triage Stage: UnreviewedAccepted
Version: 1.9a11.8

Maybe it would work to use get_script_prefix() for the site url if self.site_url == '/' in AdminSite.each_context().

comment:3 in reply to:  2 Changed 7 years ago by Dheerendra Rathor

Replying to timgraham:

Maybe it would work to use get_script_prefix() for the site url if self.site_url == '/' in AdminSite.each_context().

I replaced 'site_url': self.site_url, in my django.contrib.admin.sites.AdminSite#each_context to 'site_url': get_script_prefix(), and then I got expected result.

IMHO we don't need self.site_url == '/' check since site_url is used only once and get_script_prefix() returns / for sites hosted at root.

Last edited 7 years ago by Dheerendra Rathor (previous) (diff)

comment:4 Changed 7 years ago by Tim Graham

The if statement is needed because if someone customizes site_url, then we don't want to ignore the value that they set.

comment:5 Changed 7 years ago by Tim Graham

Has patch: set

comment:6 Changed 7 years ago by Tim Graham

Needs documentation: set

comment:7 Changed 7 years ago by Tim Graham <timograham@…>

Resolution: fixed
Status: newclosed

In 59e85f0:

Fixed #25519 -- Made the admin "View site" link point to sites running on a subpath.

Used request.METASCRIPT_NAME? as the site_url if it hasn't been
customized from the default value of '/'.

Note: See TracTickets for help on using tickets.
Back to Top